Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function-calc-no-unspaced-operator should support newer calc functions #7618

Closed
21 tasks done
Mouvedia opened this issue Apr 16, 2024 · 2 comments · Fixed by #7655
Closed
21 tasks done

function-calc-no-unspaced-operator should support newer calc functions #7618

Mouvedia opened this issue Apr 16, 2024 · 2 comments · Fixed by #7655
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@Mouvedia
Copy link
Contributor

Mouvedia commented Apr 16, 2024 •
edited

What is the problem you're trying to solve?

fix the false negatives for round and other calc-sum functions by broadening the meaning of calc to calc-sum

It doesn't validate any of the newer math functions.

compare https://www.w3.org/TR/css-values-4/#calc-syntax and https://www.w3.org/TR/css-values-3/#calc-syntax

What solution would you like to see?

I already have it working on a local branch for a subset of these.

  • abs
  • acos
  • asin
  • atan
  • calc
  • cos
  • exp
  • sign
  • sin
  • sqrt
  • tan
  • min
  • max
  • hypot
  • clamp
  • round
  • mod
  • rem
  • atan2
  • pow
  • log
@Mouvedia Mouvedia added the status: needs discussion triage needs further discussion label Apr 16, 2024
@Mouvedia Mouvedia assigned Mouvedia and unassigned Mouvedia Apr 16, 2024
@Mouvedia Mouvedia mentioned this issue Apr 16, 2024
Merged
@ybiquitous ybiquitous added status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules type: bug a problem with a feature or rule and removed status: needs discussion triage needs further discussion type: enhancement a new feature that isn't related to rules labels Apr 18, 2024
@ybiquitous
Copy link
Member

@Mouvedia If this issue is incomplete, feel free to reopen. 🙏🏼

@Mouvedia Mouvedia reopened this Apr 18, 2024
@Mouvedia
Copy link
Contributor Author

@Mouvedia If this issue is incomplete, feel free to reopen. 🙏🏼

I did a partial quick fix. A follow-up PR will be needed to fix the last 10 functions.
I added skipped tests to pave the way.

@Mouvedia Mouvedia added status: ready to implement is ready to be worked on by someone and removed status: wip is being worked on by someone labels Apr 18, 2024
@Mouvedia Mouvedia mentioned this issue Apr 22, 2024
Open
5 tasks
@Mouvedia Mouvedia mentioned this issue May 1, 2024
Merged
@ybiquitous ybiquitous added status: wip is being worked on by someone and removed status: ready to implement is ready to be worked on by someone labels May 1, 2024
@ybiquitous ybiquitous mentioned this issue May 1, 2024
Merged
ybiquitous added a commit that referenced this issue May 1, 2024
@ybiquitous
Add changelog entry for #7618
d1d0f6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix function-calc-no-unspaced-operator false negatives stylelint/stylelint
2 participants
@Mouvedia @ybiquitous