Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreProperties option to length-zero-no-unit #7591

Closed
Mouvedia opened this issue Apr 2, 2024 · 2 comments
Closed

Add ignoreProperties option to length-zero-no-unit #7591

Mouvedia opened this issue Apr 2, 2024 · 2 comments
Labels
status: needs discussion triage needs further discussion

Comments

@Mouvedia
Copy link
Contributor

Mouvedia commented Apr 2, 2024

use case

flex used to require an unit for the flex-basis value.

unitless zero will either be interpreted as one of the flexibilities, or is a syntax error

browsers affected: IE10–11

What solution would you like to see?

{
  "length-zero-no-unit": [true,  {
    "ignoreProperties": ["flex"]
  }]
}
@Mouvedia Mouvedia added the status: needs discussion triage needs further discussion label Apr 2, 2024
@ybiquitous
Copy link
Member

@Mouvedia Thanks for the report. But, flex is specially handled already. See #5315. Is a new option still necessary?

if (isFlex(prop)) return;

@Mouvedia
Copy link
Contributor Author

Mouvedia commented Apr 5, 2024

Indeed.

Is a new option still necessary?

No it's not.

see #4831 for the reason

@Mouvedia Mouvedia closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion triage needs further discussion
Development

No branches or pull requests

2 participants