Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GitHub formatter #7447

Open
jeddy3 opened this issue Jan 7, 2024 · 8 comments
Open

Deprecate GitHub formatter #7447

jeddy3 opened this issue Jan 7, 2024 · 8 comments
Labels
status: ask to implement ask before implementing as may no longer be relevant type: enhancement a new feature that isn't related to rules

Comments

@jeddy3
Copy link
Member

jeddy3 commented Jan 7, 2024

What is the problem you're trying to solve?

Ref: #7430 (comment)

What solution would you like to see?

Deprecate the GitHub formatter and remove it in the next major release.

Ideally, we'd link to a newly published GitHub custom formatter as part of the deprecation changelog entry.

@jeddy3 jeddy3 added the status: needs discussion triage needs further discussion label Jan 7, 2024
@JounQin
Copy link
Member

JounQin commented Jan 7, 2024

Deprecate it in a minor version and remove it in a major version?

@jeddy3
Copy link
Member Author

jeddy3 commented Jan 7, 2024

Yes, that's correct. There'll be a separate issue for removing it. And we won't work on that one until we start on 17.0.0 further down the line.

@Mouvedia
Copy link
Contributor

Mouvedia commented Jan 9, 2024

If we remove it and link a package in the documentation, I'd support the deprecation/removal.

IMHO it should be accompanied by the integration of a JUnit formatter; probably based on stylelint-junit-formatter.
The reason being that it's used by Circle CI, Bitbucket and Bamboo.
i.e. it's a de facto common format which addition is warranted

@ybiquitous
Copy link
Member

When I looked for candidates, I found 2 packages:

So I'll contact an author of stylelint-actions-formatters.

@ybiquitous
Copy link
Member

I just added stylelint-actions-formatters in stylelint/awesome-stylelint#70

@ybiquitous
Copy link
Member

So I'll contact an author of stylelint-actions-formatters.

Done: xt0rted/stylelint-actions-formatters#187

@ybiquitous ybiquitous added status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules and removed status: needs discussion triage needs further discussion labels Mar 23, 2024
@ybiquitous
Copy link
Member

Since I found an alternative package, I've labeled the issue as ready to implement. Please consider contributing if you have time.

process.emitWarning() like #7550 will output a deprecation warning if --formatter=github or stylelint.lint({ formatter: 'github' }) is used.

After this warning is released in a minor version (e.g. 16.x.y), let's remove the formatter in the next major version (17.0.0).

Copy link
Contributor

This issue is older than one month. Please ask before opening a pull request, as it may no longer be relevant.

@github-actions github-actions bot added status: ask to implement ask before implementing as may no longer be relevant and removed status: ready to implement is ready to be worked on by someone labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ask to implement ask before implementing as may no longer be relevant type: enhancement a new feature that isn't related to rules
Development

No branches or pull requests

4 participants