Fix unexpected output in Node.js API lint result when any rule contains disableFix: true
#6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue` stylelint#6542 fixes stylelint#6542 and bv that should also fix stylelint/vscode-stylelint#369 Issue: The API did not return the fixed css in `output` if any rule contained `ruleDisableFix`. I have removed the `ruleDisableFix` code, because it did not affect the code fixing itself and was assumingly wrongly used to change the content format of `output`. I have adjusted some tests to adapt to the changed behaviour and extended the test conditions to check that the returned code has the correct fixes applied. Issue was introduced in stylelint#5460
🦋 Changeset detectedLatest commit: b670fe4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
ybiquitous
reviewed
Dec 28, 2022
ybiquitous
changed the title
disableFix: true #6542output in Node.js API lint result when any rule contains disableFix: true
jeddy3
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6542
and by that should also fix stylelint/vscode-stylelint#369
Issue: The API did not return the fixed css in
outputif any rule containedruleDisableFix.I have removed the
ruleDisableFixcode, because it did not affect the code fixing itself and I assume was wrongly used to change the content format ofoutput. I have adjusted some tests to adapt to the changed behavior and extended the test conditions to check that the returned code has the correct fixes applied.Issue was introduced in #5460