Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customSyntax resolution with configBasedir #6536

Merged
merged 5 commits into from Dec 24, 2022
Merged

Fix customSyntax resolution with configBasedir #6536

merged 5 commits into from Dec 24, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Dec 22, 2022

Which issue, if any, is this issue related to?

Ref #6525

Is there anything in the PR that needs further explanation?

This PR fixes resolution of the customSyntax (--custom-syntax) option. The option should be able to be read from configBasedir (--config-basedir) like plugins or extends.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2022

🦋 Changeset detected

Latest commit: d8c1d7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous marked this pull request as ready for review December 22, 2022 13:39
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Although, it doesn't fix the reported case. This is a bug we should fix, right?

@ybiquitous
Copy link
Member Author

Although, it doesn't fix the reported case. This is a bug we should fix, right?

Yes, right. So I've updated Closes #6525 to Ref #6525 in this PR description.

@ybiquitous ybiquitous merged commit c0db3fd into main Dec 24, 2022
@ybiquitous ybiquitous deleted the issue-6525 branch December 24, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants