Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message arguments to at-rule-disallowed-list #6461

Closed
chloerice opened this issue Nov 10, 2022 · 3 comments · Fixed by #6463
Closed

Add message arguments to at-rule-disallowed-list #6461

chloerice opened this issue Nov 10, 2022 · 3 comments · Fixed by #6463
Labels
status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules

Comments

@chloerice
Copy link
Contributor

What is the problem you're trying to solve?

In the same vein as #6453, #6454, and #6455, I'd love to be able to access the name of the at rule that's rejected by at-rule-disallowed-list so that I can map it to a custom message and relevant documentation link.

What solution would you like to see?

report({
- message: messages.rejected(name),
+ message: messages.rejected,
+ messageArgs: [name],
  node: atRule,
  result,
  ruleName,
  word: `@${atRule.name}`,
});
@ybiquitous ybiquitous added status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules labels Nov 10, 2022
@ybiquitous
Copy link
Member

@chloerice Thanks for the proposal. I agree.

I've labeled the issue as ready to implement. Please consider contributing if you have time.

@chloerice
Copy link
Contributor Author

chloerice commented Nov 10, 2022

Would be it preferred that I submit one PR for each issue (this issue + #6453, #6454, #6455, and #6462), or can I submit a single PR adding messageArg support for all 5 of these rules?

@ybiquitous
Copy link
Member

ybiquitous commented Nov 10, 2022

Submitting a single PR that addresses all issues together is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules
Development

Successfully merging a pull request may close this issue.

2 participants