New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to checkAgainstRule
with custom rules
#6460
Add support to checkAgainstRule
with custom rules
#6460
Conversation
🦋 Changeset detectedLatest commit: 7aab43b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@aaronccasanova Thanks for creating the pull request.
Yes, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for adding good test cases. Also, the refactoring you introduced is so nice.
This PR is good enough, but I suggest additional refactorings to improve the code quality. If possible, please consider addressing my reviews.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…casanova/stylelint into check-against-custom-rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring. The code is now more straightforward and readable. I've left comments for tiny suggestions.
Could you add a minor
changelog entry following the guideline on #6460 (comment) like this?
Added: support to `checkAgainstRule` with custom rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
Thanks for the reviews and feedback @ybiquitous! I'm very happy with the additional code quality wins we were able to include in this PR 👍 |
Closes #6446
checkAgainstRule
with custom rulesresult
optionnormalizeRuleSettings
utility to handle custom rulescheckAgainstRule
documentation to describe the new behavior