New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test glob with parent directory #6398
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjarva Thanks for opening the pull request. The added tests look good to me. 👍🏼
By the way, a linting job in CI fails. Could you fix it, please?
…') and paren + wildcard directory ('../**/style.css')
f2079e5
to
386a3fb
Compare
…rom causing a formatter error
Absolutely! I'm not totally sure did I fix it correctly, because the first time that I ran I added the new test folder to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #3273
I think that these added unit tests should have been in
__tests__/standalone-globs.test.js
, but as the needed test case has to have the styles in a parent directory, and all unit tests have to be in__tests__
, I created a new folderstandalone-glob-parent-test
that contains all the needed files.I also created a unit test that has a parent directory (
../
) and a wildcard (**/
) in theglob
, since although this is not very common, it's a possible case. And as the documentation says that[the unit tests] should be comprehensive and systematic
, I thought this is a valid test case to have.