Fix block-no-empty false positives for reportNeedlessDisables

[ybiquitous]

Which issue, if any, is this issue related to?

Closes #5388

Is there anything in the PR that needs further explanation?

As suggested in #5388 (comment), this PR extracts a new utility from assignDisabledRanges.js, and then it ignores a Stylelint command comment in the block-no-empty rule by using the new utility.

[changeset-bot]

🦋 Changeset detected

Latest commit: a30c5c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ybiquitous]

[note] It should be more readable and less duplicated thanks to hasBlock:

stylelint/lib/utils/hasBlock.js

Lines 9 to 11 in 736bc29

	module.exports = function hasBlock(statement) {
	return statement.nodes !== undefined;
	};

[ybiquitous]

[note] Since ''.split(/\s/, 1) returns [''], this assertString should prevent command is undefined.

[jeddy3]

This is fantastic, thanks!

LGTM.

[AlexSkrypnyk]

Looks like this change broke correct ignore rules that worked before:

  &__top__content-top1 {
    // stylelint-disable-line block-no-empty
  }

results in

 24:24  ✖  Unexpected empty block  block-no-empty

$ npm list stylelint
├─┬ stylelint-config-standard-scss@2.0.1
│ ├─┬ stylelint-config-recommended-scss@5.0.2
│ │ ├─┬ stylelint-scss@4.3.0
│ │ │ └── stylelint@14.14.0 deduped
│ │ └── stylelint@14.14.0 deduped
│ └── stylelint@14.14.0 deduped
├─┬ stylelint-config-standard@23.0.0
│ ├─┬ stylelint-config-recommended@6.0.0
│ │ └── stylelint@14.14.0 deduped
│ └── stylelint@14.14.0 deduped
└── stylelint@14.14.0

[AlexSkrypnyk]

Ok, this works

  &__middle__content-middle1 {
    // stylelint-disable-block block-no-empty
  }

I could not find any information in this PR or the release about changes to the disable rule for blocks: from stylelint-disable-line to stylelint-disable-block

[ybiquitous]

@AlexSkrypnyk stylelint-disable-block is not a valid Stylelint command. So the code above is equal to the following code using a non-special comment:

&__middle__content-middle1 {
  // This block is not empty because of including this comment
}

You can see it on the demo.

It seems you need to fix the code as below:

&__top__content-top1 { // stylelint-disable-line block-no-empty
}

Or

// stylelint-disable-next-line block-no-empty
&__top__content-top1 {
}

Or

&__top__content-top1 {
  // You can put any command except for the Stylelint commands here.
}