Refactor to add test utils #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ybiquitous
force-pushed
the
refactor-to-add-test-utils
branch
from
dda3751
to
3317e73
Compare
New helpers aim to reduce duplication in the test code.
ybiquitous
force-pushed
the
refactor-to-add-test-utils
branch
from
3317e73
to
7043eff
Compare
ybiquitous
commented
Sep 22, 2022
| @@ -38,8 +31,9 @@ function getConfig(additional = {}) { | |||
| } | |||
|
|
|||
| describe('standalone cache', () => { | |||
| // HACK: The test may fail depending on the timing of the access to the cache file. See #5531 | |||
| jest.retryTimes(3); | |||
| const cwd = path.join(__dirname, 'tmp', 'standalone-cache'); | |||
There was a problem hiding this comment.
[note] I believe a flaky test problem like #5531 will not occur in the future.
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None.
New helpers aim to reduce duplication in the test code.