Fix cache refresh when config is changed #6356
Conversation
🦋 Changeset detectedLatest commit: 4b5b1c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This lint error does not occur local. I'm checking this error. |
|
The reason the error did not occur on my local was that this change was not merged. |
There was a problem hiding this comment.
@kimulaco Thanks for creating the pull request.
I've commented on several refactoring suggestions. Please consider addressing them.
|
Due to #6358, there is a conflict. Can you please fix it? |
|
@kimulaco thanks for tackling the oldest non-upstream bug. |
ybiquitous
changed the title
There was a problem hiding this comment.
@kimulaco Thank you for addressing the reviews.
I've left a suggestion for the test, but the code looks almost good enough to merge.
|
@ybiquitous Thanks for reviews. I understood stylelint better than ever. |
There was a problem hiding this comment.
@kimulaco Thank you for fixing the bug, LGTM!
@ybiquitous Thank you for the fantastic reviewing!
…6393) This type import was added in #6356, but during code review that PR was refactored to obviate the `file-entry-cache` types in the public API. The import was never removed. Keeping the import here results in [compilation errors](https://app.circleci.com/pipelines/github/palantir/blueprint/3156/workflows/9eda97ec-3a2f-4aa6-aa6c-89d5b65b8491/jobs/61694) for downstream consumers: ``` ../../node_modules/stylelint/types/stylelint/index.d.ts:5:39 - error TS7016: Could not find a declaration file for module 'file-entry-cache'. '/home/circleci/project/node_modules/file-entry-cache/cache.js' implicitly has an 'any' type. Try `npm i --save-dev @types/file-entry-cache` if it exists or add a new declaration (.d.ts) file containing `declare module 'file-entry-cache';` 5 import type * as fileEntryCache from 'file-entry-cache' ```
Closes #2908
Currently, there is a problem with cached file messages not being displayed. This report already exists. #4715
So the test I have added is not optimal. I don't know how to prove that the file is cached in the CLI.