Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 14.4.0 #5884

Closed
6 tasks done
jeddy3 opened this issue Feb 6, 2022 · 6 comments
Closed
6 tasks done

Release 14.4.0 #5884

jeddy3 opened this issue Feb 6, 2022 · 6 comments
Labels
status: wip is being worked on by someone

Comments

@jeddy3
Copy link
Member

jeddy3 commented Feb 6, 2022

  • stylelint release
  • stylelint-config-recommended update/release
  • stylelint-config-standard update/release
  • stylelint-demo update
  • stylelint.io update
  • tweet

Let's release once the following land:

And we've then prep pull requests for the configs as we'll be including function-no-unknown in recommended.

@jeddy3 jeddy3 added the status: needs discussion triage needs further discussion label Feb 6, 2022
@jeddy3
Copy link
Member Author

jeddy3 commented Feb 7, 2022

Prep pull requests ready for review at:

@jeddy3
Copy link
Member Author

jeddy3 commented Feb 8, 2022

I'm getting an ESLint error locally that'll stop me from publishing.

Is anyone else getting this locally or does anyone have any thoughts on what may be triggering it?

The CI is green.

jeddy3@MacBook stylelint % git pull
Already up to date.
jeddy3@MacBook stylelint % rm -rf node_modules 
jeddy3@MacBook stylelint % npm i

> stylelint@14.3.0 prepare
> husky install

husky - Git hooks installed

added 1082 packages, and audited 1083 packages in 37s

266 packages are looking for funding
  run `npm fund` for details

11 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
jeddy3@MacBook stylelint % npm run lint:js

> stylelint@14.3.0 lint:js
> eslint . --cache --max-warnings=0


/Users/jeddy3/Projects/stylelint/lib/rules/function-no-unknown/index.js
  6:35  error  "css-functions-list" is not found  node/no-missing-require

✖ 1 problem (1 error, 0 warnings)

jeddy3@MacBook stylelint % node --version
v16.13.2
jeddy3@MacBook stylelint % npm --version
8.3.2

/cc @gnuletik as connected to the function-no-unknown rule.

I'm hesitant to silence the warning in case it's legitimately flagging a potential issue with some system configurations.

@ybiquitous
Copy link
Member

In my environment, it works. How about npm run lint:js -- --no-cache?

@jeddy3
Copy link
Member Author

jeddy3 commented Feb 8, 2022

How about npm run lint:js -- --no-cache?

Bingo, thanks! That fixed it. First time I've encountered an ESLint caching issue.

I'll likely release later today.

@jeddy3 jeddy3 added status: wip is being worked on by someone and removed status: needs discussion triage needs further discussion labels Feb 8, 2022
@jeddy3
Copy link
Member Author

jeddy3 commented Feb 8, 2022

Done 🎉. The demo didn't deploy automatically. I had to trigger a manual deployment. Not sure why. Let's keep an eye on it for the next release.

Thank you to everyone who added features, fixed bugs, wrote docs, refactored code, reviewed pull requests and so on for this release!

@jeddy3 jeddy3 closed this as completed Feb 8, 2022
@ybiquitous
Copy link
Member

@jeddy3 Thanks for the release! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone
Development

No branches or pull requests

2 participants