Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError for syntaxes that use Document in indentation #5771

Merged
merged 1 commit into from Dec 20, 2021
Merged

Fix TypeError for syntaxes that use Document in indentation #5771

merged 1 commit into from Dec 20, 2021

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Dec 10, 2021 •
edited

Fixes #5767

I changed beforeStart to codeBefore and added a truthy check

ybiquitous
ybiquitous reviewed Dec 12, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@43081j Thank you for creating this PR!
I've left some trivial suggestions, but this is mostly good to me. 👍🏼

lib/rules/indentation/__tests__/document-with-roots.js Outdated Show resolved Hide resolved
lib/rules/indentation/index.js Outdated Show resolved Hide resolved
@jeddy3 jeddy3 changed the title fix (indentation): replace beforeStart with codeBefore Fix TypeError for syntaxes that use Document in indentation Dec 18, 2021
@43081j
Copy link
Contributor Author

43081j commented Dec 20, 2021 •
edited

sorry this got a bit lost @ybiquitous , i've updated it now with what you said

ybiquitous
ybiquitous approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@43081j Thank you! LGTM 👍🏼

jeddy3
jeddy3 reviewed Dec 20, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jeddy3 jeddy3 merged commit 8b066db into stylelint:main Dec 20, 2021
@jeddy3
Copy link
Member

jeddy3 commented Dec 20, 2021

  • Fixed: indentation TypeError for syntaxes that use Document node type (#5771).

@43081j 43081j deleted the indentation-codebefore branch December 20, 2021 18:44
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TypeError for syntaxes that use Document in indentation
3 participants
@43081j @jeddy3 @ybiquitous