Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function-calc-no-invalid was removed and replacement is non-existent or undocumented #5713

Closed
romainmenke opened this issue Nov 10, 2021 · 2 comments
Labels
status: needs discussion triage needs further discussion type: documentation an improvement to the documentation

Comments

@romainmenke
Copy link
Member

romainmenke commented Nov 10, 2021

What steps are needed to reproduce the bug?

Have a stylelint config with function-calc-no-invalid in it.

What Stylelint configuration is needed to reproduce the bug?

{
  "rules": { "function-calc-no-invalid": "<any value>" }
}

How did you run Stylelint?

Any method

Which version of Stylelint are you using?

^14

What did you expect to happen?

No errors or documentation on where to find a replacement

What actually happened?

Unknown rule function-calc-no-invalid function-calc-no-invalid

Does the bug relate to non-standard syntax?

No

Proposal to fix the bug

Write migration/deprecation docs.


This issue discusses moving it to a separate plugin : #4731 (comment)

But I can't find it anywhere.

The PR specifically mentions not doing any kind of deprecation cycle : #5296 (comment)

This issue just mentions updating a standards config :
#5653

But it does not explain why this would help or any hint of a replacement.


Can this be rectified?
I understand that some people had strong feelings about removing this rule but guiding the community is important here.

Open questions I have?

  • why is running in the browser and performance there even a factor ?!?
  • is there a replacement?
@romainmenke romainmenke changed the title function-calc-no-invalid was removed and replaced is non-existent or undecomented function-calc-no-invalid was removed and replacement is non-existent or undocumented Nov 10, 2021
@ybiquitous
Copy link
Member

@romainmenke Thank you for using a template! As far as I know, there seem to be no replacements. 😞

We have discussed performance and browser support for a long time (see #2454 and #3935).
Also, the function-calc-no-invalid rue had a problem with maintainability.

@ybiquitous ybiquitous added status: needs discussion triage needs further discussion type: documentation an improvement to the documentation labels Nov 12, 2021
@jeddy3
Copy link
Member

jeddy3 commented Nov 13, 2021

Also, the function-calc-no-invalid rue had a problem with maintainability

This was the main reason for its removal. It had a security vulnerability.

is there a replacement?

As @ybiquitous said, there is no replacement. Stylelint may, in the future, offer more validation if we migrate some rules to a different parser.

I'm going to close the issue as the migration guide says to remove the rule from your config and that's all we can suggest at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion triage needs further discussion type: documentation an improvement to the documentation
Development

No branches or pull requests

3 participants