Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 14.0.0 #5604

Merged
merged 196 commits into from Oct 21, 2021
Merged

Prepare 14.0.0 #5604

merged 196 commits into from Oct 21, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Oct 19, 2021

Which issue, if any, is this issue related to?

Relates to #5205

Is there anything in the PR that needs further explanation?

Of the 3 merge options, I assume we'll want to "create a merge commit" as that'll preserve the commits into master?

I'll merge this when we're ready to go. There are quite a few moving parts in this release, and I'll need to block out some time to do it. Tomorrow is a good day for me to do that (if the VS Code extension is OK).

In the meantime, I'm going to do some local testing on this branch. Pulling down this branch and checking it works with your project, would be helpful!

jeddy3 and others added 30 commits May 14, 2021 07:15
* Remove function-calc-no-invalid

* Remove calc parser

* Remove ignoring of calc parser
This change is a part of the next major version (v14).

- Remove Node 10 from CI
- Update `engines.node`

In addition, this removes needless `CI: true` (just a refactoring).
See <https://github.blog/changelog/2020-04-15-github-actions-sets-the-ci-environment-variable-to-true/>
We will no longer need the polyfill on the next major release (v14).
* Add lang to code blocks in Markdown

This change aims to make documents more readable and avoid syntax errors
by adding a language specifier to code blocks in Markdown.

To perform this task efficiently, I use two remark plugins:
- [remark-lint-code-block-syntax](https://github.com/ybiquitous/remark-lint-code-block-syntax)
- [remark-lint-fenced-code-flag](https://github.com/remarkjs/remark-lint/tree/main/packages/remark-lint-fenced-code-flag)

```diff
--- a/package.json
+++ b/package.json
@@ -66,7 +66,9 @@
   },
   "remarkConfig": {
     "plugins": [
-      "@stylelint/remark-preset"
+      "@stylelint/remark-preset",
+      "remark-lint-code-block-syntax",
+      "remark-lint-fenced-code-flag"
     ]
   },
   "jest": {
@@ -189,6 +191,8 @@
     "postcss-import": "^12.0.1",
     "prettier": "^2.2.1",
     "remark-cli": "^9.0.0",
+    "remark-lint-code-block-syntax": "^0.2.1",
+    "remark-lint-fenced-code-flag": "^2.0.1",
     "typescript": "^4.2.4"
   },
   "engines": {
```

Note: I do not recommend the addition of the plugins because they produce false positives.

* Remove deprecated files

* Remove deprecated files again
* Refactor `lib/__tests__/standalone-cache.test.js`

- Reduce redundant callbacks via `async/await` syntax. (#4881)
- Use `fs.existsSync()` instead of `fs.access()`.
  See <https://nodejs.org/api/fs.html#fs_fs_existssync_path>
- Fix the disabled test. (#5309)
- Inline redundant local variables.
- Make expectations using `typeof` more accurate.

* Reduce local variables by improving `getConfig()`
@jeddy3 jeddy3 mentioned this pull request Oct 19, 2021
30 tasks
@ybiquitous
Copy link
Member

Of the 3 merge options, I assume we'll want to "create a merge commit" as that'll preserve the commits into master?

Yes, I think so. 👍🏼

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 19, 2021

Coverage is down 1.1% but I think that's fine.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

When testing locally I ran into an issue. The overrides property isn't activated if:

  • the --config flag is used
  • the config is in a sub directory

Given test.scss:

@mixin name($var) {
  &:#{$var} {
  }
}

test.json:

{
  "rules": {
    "block-no-empty": null
  },
  "overrides": [
    {
      "files": ["**/*.scss"],
      "customSyntax": "postcss-scss",
      "rules": {
        "block-no-empty": true
      }
    }
  ]
}

If test.json is in the root:

jeddy3@mac stylelint-test % npx stylelint test.scss --config test.json 

test.scss
 2:13  ✖  Unexpected empty block  block-no-empty

But if it's in a subfolder, e.g. sub:

npx stylelint test.scss --config sub/test.json
When linting something other than CSS, you should install an appropriate syntax, e.g. postcss-scss, and use the "customSyntax" option

test.scss
 2:7  ✖  Unknown word  CssSyntaxError

Ideas on what's going on and how to fix?


Reducing this issue down to this reproducible case took a bit of wrangling. The good news is that once I narrowed down the problem, I was able to adjust my local test setup to work around it and everything else seems to work. For example, I'm using all the syntaxes across test files:

{
  "rules": {
    "block-no-empty": true,
  },
  "overrides": [
    {
      "files": ["**/*.scss"],
      "customSyntax": "postcss-scss"
    },
    {
      "files": ["**/*.md"],
      "customSyntax": "postcss-markdown"
    },
    {
      "files": ["**/*.{js,ts}"],
      "customSyntax": "@stylelint/postcss-css-in-js"
    },
    {
      "files": ["**/*.{html,vue,svelte}"],
      "customSyntax": "postcss-html"
    },
    {
      "files": ["**/*.sss"],
      "customSyntax": "sugarss"
    },
    {
      "files": ["**/*.less"],
      "customSyntax": "postcss-less"
    }
  ]
}

@ntwb
Copy link
Member

ntwb commented Oct 20, 2021

I'm currently trying to test v14 with VS Code here stylelint/vscode-stylelint#265 (comment)

I'm struggling to get npm link to work to test v14

I was thinking we could publish to https://www.npmjs.com/package/stylelint a next pre-release release

  • ./node_modules/.bin/np --preview --any-branch --no-release-draft

Results look good, here's the full output of that command, note the --preview for a trial run:

❯ ./node_modules/.bin/np --preview --any-branch --no-release-draft
? The following new files will not be part of your published package:
- types/normalize-selector/index.d.ts
- types/postcss-media-query-parser/index.d.ts
- types/postcss-resolve-nested-selector/index.d.ts
- types/stylelint/type-test.ts
The following new files will be published the first time:
- docs/migration-guide/to-14.md
- lib/__tests__/applyOverrides.test.js
- lib/__tests__/fixtures/config-overrides/extending-plugin-and-one-rule.json
- lib/__tests__/fixtures/config-overrides/extending-simple-rule.json
- lib/__tests__/fixtures/config-overrides/extends-in-overrides.json
- lib/__tests__/fixtures/config-overrides/plugin-and-one-rule.json
- lib/__tests__/fixtures/config-overrides/simple-rule.json
- lib/__tests__/fixtures/config-overrides/style.css
- lib/__tests__/fixtures/config-overrides/style.module.css
- lib/__tests__/fixtures/config-overrides/testPrintConfig/.stylelintrc
- lib/__tests__/fixtures/config-overrides/testPrintConfig/style.css
- lib/__tests__/overrides.test.js
- lib/rules/color-hex-alpha/__tests__/index.js
- lib/rules/color-hex-alpha/index.js
- lib/rules/custom-property-no-missing-var-function/__tests__/index.js
- lib/rules/custom-property-no-missing-var-function/index.js
- lib/testUtils/uniqueId.js
- lib/utils/__tests__/arrayEqual.test.js
- lib/utils/__tests__/isAutoprefixable.test.js
- lib/utils/__tests__/isStandardSyntaxComment.test.js
- lib/utils/arrayEqual.js
- lib/utils/isPathNotFoundError.js
- lib/utils/isStandardSyntaxComment.js
- lib/utils/validateTypes.js
Continue? Yes

Publish a new version of stylelint (current: 13.13.1)

Commits:
- Prepare 14.0.0  5dd7ec15
- Add support for `extends` in `overrides` config (#5603)  67313a38
- ** Truncated for readability **
- Refactor `lib/__tests__/extends.test.js` (#5280)  af6f858e
- Mention alternative integration with Emacs (#5275)  20dc873f

Commit Range:
13.13.1...master

Registry:
https://registry.npmjs.org/

? Select semver increment or specify new version premajor       14.0.0-0
? How should this pre-release version be tagged in npm? next

  ✔ Prerequisite check
  ✔ Git
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ↓ Bumping version using npm [skipped]
    → [Preview] Command not executed: npm version 14.0.0-0.
  ↓ Publishing package using npm [skipped]
    → [Preview] Command not executed: npm publish --tag next.
  ↓ Pushing tags [skipped]
    → [Preview] Command not executed: git push --follow-tags.
~/Code/stylelint/stylelint v14 *2                                     

At the end of this process we would have a next tag at https://github.com/stylelint/stylelint/tree/next and a next release on npm https://www.npmjs.com/package/stylelint

And we could install this next version via npm install --dev stylelint@next

Thoughts @stylelint/owners ?

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

Go for it.

The inclusion of __tests__ in that list doesn't look right. However, the npm publish --dry-run looks fine so I think we're good:

Dry run output ``` jeddy3@mac stylelint % npm publish --dry-run npm notice npm notice 📦 stylelint@13.13.1 npm notice === Tarball Contents === npm notice 127.1kB CHANGELOG.md npm notice 4.2kB CONTRIBUTING.md npm notice 1.1kB LICENSE npm notice 4.2kB README.md npm notice 169B bin/stylelint.js npm notice 2.1kB docs/about/linting.md npm notice 1.5kB docs/about/semantic-versioning.md npm notice 2.5kB docs/about/vision.md npm notice 2.3kB docs/developer-guide/formatters.md npm notice 10.1kB docs/developer-guide/plugins.md npm notice 1.1kB docs/developer-guide/processors.md npm notice 8.6kB docs/developer-guide/rules.md npm notice 1.1kB docs/developer-guide/syntaxes.md npm notice 965B docs/developer-guide/system-tests.md npm notice 3.3kB docs/maintainer-guide/issues.md npm notice 1.8kB docs/maintainer-guide/pull-requests.md npm notice 2.7kB docs/maintainer-guide/releases.md npm notice 7.0kB docs/migration-guide/to-14.md npm notice 14.4kB docs/user-guide/configure.md npm notice 849B docs/user-guide/errors.md npm notice 6.3kB docs/user-guide/get-started.md npm notice 2.7kB docs/user-guide/ignore-code.md npm notice 1.2kB docs/user-guide/integrations/editor.md npm notice 1.1kB docs/user-guide/integrations/other.md npm notice 723B docs/user-guide/integrations/task-runner.md npm notice 6.5kB docs/user-guide/rules/about.md npm notice 10.9kB docs/user-guide/rules/combine.md npm notice 30.9kB docs/user-guide/rules/list.md npm notice 874B docs/user-guide/rules/regex.md npm notice 5.4kB docs/user-guide/usage/cli.md npm notice 3.8kB docs/user-guide/usage/node-api.md npm notice 7.0kB docs/user-guide/usage/options.md npm notice 3.3kB docs/user-guide/usage/postcss-plugin.md npm notice 10.5kB lib/assignDisabledRanges.js npm notice 13.3kB lib/augmentConfig.js npm notice 13.7kB lib/cli.js npm notice 3.0kB lib/createPartialStylelintResult.js npm notice 359B lib/createPlugin.js npm notice 1.8kB lib/createStylelint.js npm notice 1.2kB lib/createStylelintResult.js npm notice 2.0kB lib/descriptionlessDisables.js npm notice 371B lib/formatters/compactFormatter.js npm notice 607B lib/formatters/index.js npm notice 472B lib/formatters/jsonFormatter.js npm notice 6.1kB lib/formatters/stringFormatter.js npm notice 797B lib/formatters/tapFormatter.js npm notice 495B lib/formatters/unixFormatter.js npm notice 2.1kB lib/formatters/verboseFormatter.js npm notice 2.1kB lib/getConfigForFile.js npm notice 4.4kB lib/getPostcssResult.js npm notice 801B lib/index.js npm notice 1.5kB lib/invalidScopeDisables.js npm notice 1.4kB lib/isPathIgnored.js npm notice 4.1kB lib/lintPostcssResult.js npm notice 3.3kB lib/lintSource.js npm notice 3.3kB lib/needlessDisables.js npm notice 928B lib/normalizeAllRuleSettings.js npm notice 2.3kB lib/normalizeRuleSettings.js npm notice 999B lib/postcssPlugin.js npm notice 1.6kB lib/prepareReturnValue.js npm notice 1.3kB lib/printConfig.js npm notice 13.6kB lib/reference/keywordSets.js npm notice 65B lib/reference/mathFunctions.js npm notice 5.9kB lib/reference/namedColorData.js npm notice 279B lib/reference/propertySets.js npm notice 246B lib/reference/punctuationSets.js npm notice 3.8kB lib/reference/shorthandData.js npm notice 2.0kB lib/reportDisables.js npm notice 1.9kB lib/reportUnknownRuleNames.js npm notice 4.8kB lib/rules/alpha-value-notation/index.js npm notice 1.8kB lib/rules/alpha-value-notation/README.md npm notice 1.4kB lib/rules/at-rule-allowed-list/index.js npm notice 918B lib/rules/at-rule-allowed-list/README.md npm notice 1.4kB lib/rules/at-rule-disallowed-list/index.js npm notice 723B lib/rules/at-rule-disallowed-list/README.md npm notice 5.3kB lib/rules/at-rule-empty-line-before/index.js npm notice 6.4kB lib/rules/at-rule-empty-line-before/README.md npm notice 1.3kB lib/rules/at-rule-name-case/index.js npm notice 1.6kB lib/rules/at-rule-name-case/README.md npm notice 987B lib/rules/at-rule-name-newline-after/index.js npm notice 1.7kB lib/rules/at-rule-name-newline-after/README.md npm notice 1.2kB lib/rules/at-rule-name-space-after/index.js npm notice 1.8kB lib/rules/at-rule-name-space-after/README.md npm notice 1.6kB lib/rules/at-rule-no-unknown/index.js npm notice 1.1kB lib/rules/at-rule-no-unknown/README.md npm notice 1.2kB lib/rules/at-rule-no-vendor-prefix/index.js npm notice 866B lib/rules/at-rule-no-vendor-prefix/README.md npm notice 1.5kB lib/rules/at-rule-property-required-list/index.js npm notice 990B lib/rules/at-rule-property-required-list/README.md npm notice 1.8kB lib/rules/at-rule-semicolon-newline-after/index.js npm notice 1.1kB lib/rules/at-rule-semicolon-newline-after/README.md npm notice 1.5kB lib/rules/at-rule-semicolon-space-before/index.js npm notice 922B lib/rules/at-rule-semicolon-space-before/README.md npm notice 1.2kB lib/rules/atRuleNameSpaceChecker.js npm notice 3.2kB lib/rules/block-closing-brace-empty-line-before/index.js npm notice 2.9kB lib/rules/block-closing-brace-empty-line-before/README.md npm notice 3.7kB lib/rules/block-closing-brace-newline-after/index.js npm notice 3.5kB lib/rules/block-closing-brace-newline-after/README.md npm notice 3.6kB lib/rules/block-closing-brace-newline-before/index.js npm notice 1.5kB lib/rules/block-closing-brace-newline-before/README.md npm notice 2.3kB lib/rules/block-closing-brace-space-after/index.js npm notice 3.2kB lib/rules/block-closing-brace-space-after/README.md npm notice 2.7kB lib/rules/block-closing-brace-space-before/index.js npm notice 2.8kB lib/rules/block-closing-brace-space-before/README.md npm notice 1.9kB lib/rules/block-no-empty/index.js npm notice 834B lib/rules/block-no-empty/README.md npm notice 4.4kB lib/rules/block-opening-brace-newline-after/index.js npm notice 2.1kB lib/rules/block-opening-brace-newline-after/README.md npm notice 3.1kB lib/rules/block-opening-brace-newline-before/index.js npm notice 2.9kB lib/rules/block-opening-brace-newline-before/README.md npm notice 2.6kB lib/rules/block-opening-brace-space-after/index.js npm notice 2.8kB lib/rules/block-opening-brace-space-after/README.md npm notice 3.4kB lib/rules/block-opening-brace-space-before/index.js npm notice 3.3kB lib/rules/block-opening-brace-space-before/README.md npm notice 3.2kB lib/rules/color-function-notation/index.js npm notice 2.4kB lib/rules/color-function-notation/README.md npm notice 1.9kB lib/rules/color-hex-alpha/index.js npm notice 916B lib/rules/color-hex-alpha/README.md npm notice 2.1kB lib/rules/color-hex-case/index.js npm notice 903B lib/rules/color-hex-case/README.md npm notice 2.9kB lib/rules/color-hex-length/index.js npm notice 1.1kB lib/rules/color-hex-length/README.md npm notice 5.0kB lib/rules/color-named/generateColorFuncs.js npm notice 4.5kB lib/rules/color-named/index.js npm notice 2.6kB lib/rules/color-named/README.md npm notice 1.6kB lib/rules/color-no-hex/index.js npm notice 801B lib/rules/color-no-hex/README.md npm notice 1.3kB lib/rules/color-no-invalid-hex/index.js npm notice 831B lib/rules/color-no-invalid-hex/README.md npm notice 3.4kB lib/rules/comment-empty-line-before/index.js npm notice 3.2kB lib/rules/comment-empty-line-before/README.md npm notice 1.0kB lib/rules/comment-no-empty/index.js npm notice 618B lib/rules/comment-no-empty/README.md npm notice 1.1kB lib/rules/comment-pattern/index.js npm notice 583B lib/rules/comment-pattern/README.md npm notice 3.4kB lib/rules/comment-whitespace-inside/index.js npm notice 1.6kB lib/rules/comment-whitespace-inside/README.md npm notice 1.4kB lib/rules/comment-word-disallowed-list/index.js npm notice 844B lib/rules/comment-word-disallowed-list/README.md npm notice 1.4kB lib/rules/custom-media-pattern/index.js npm notice 635B lib/rules/custom-media-pattern/README.md npm notice 4.0kB lib/rules/custom-property-empty-line-before/index.js npm notice 4.0kB lib/rules/custom-property-empty-line-before/README.md npm notice 1.9kB lib/rules/custom-property-no-missing-var-function/index.js npm notice 774B lib/rules/custom-property-no-missing-var-function/README.md npm notice 1.2kB lib/rules/custom-property-pattern/index.js npm notice 567B lib/rules/custom-property-pattern/README.md npm notice 2.3kB lib/rules/declaration-bang-space-after/index.js npm notice 1.3kB lib/rules/declaration-bang-space-after/README.md npm notice 2.4kB lib/rules/declaration-bang-space-before/index.js npm notice 1.2kB lib/rules/declaration-bang-space-before/README.md npm notice 1.4kB lib/rules/declaration-block-no-duplicate-custom-properties/index.js npm notice 817B lib/rules/declaration-block-no-duplicate-custom-properties/README.md npm notice 3.0kB lib/rules/declaration-block-no-duplicate-properties/index.js npm notice 2.6kB lib/rules/declaration-block-no-duplicate-properties/README.md npm notice 2.8kB lib/rules/declaration-block-no-redundant-longhand-properties/index.js npm notice 3.5kB lib/rules/declaration-block-no-redundant-longhand-properties/README.md npm notice 1.6kB lib/rules/declaration-block-no-shorthand-property-overrides/index.js npm notice 1.4kB lib/rules/declaration-block-no-shorthand-property-overrides/README.md npm notice 2.6kB lib/rules/declaration-block-semicolon-newline-after/index.js npm notice 2.3kB lib/rules/declaration-block-semicolon-newline-after/README.md npm notice 1.8kB lib/rules/declaration-block-semicolon-newline-before/index.js npm notice 1.8kB lib/rules/declaration-block-semicolon-newline-before/README.md npm notice 2.3kB lib/rules/declaration-block-semicolon-space-after/index.js npm notice 2.5kB lib/rules/declaration-block-semicolon-space-after/README.md npm notice 2.7kB lib/rules/declaration-block-semicolon-space-before/index.js npm notice 2.3kB lib/rules/declaration-block-semicolon-space-before/README.md npm notice 1.4kB lib/rules/declaration-block-single-line-max-declarations/index.js npm notice 757B lib/rules/declaration-block-single-line-max-declarations/README.md npm notice 2.7kB lib/rules/declaration-block-trailing-semicolon/index.js npm notice 1.9kB lib/rules/declaration-block-trailing-semicolon/README.md npm notice 2.7kB lib/rules/declaration-colon-newline-after/index.js npm notice 1.3kB lib/rules/declaration-colon-newline-after/README.md npm notice 1.9kB lib/rules/declaration-colon-space-after/index.js npm notice 1.9kB lib/rules/declaration-colon-space-after/README.md npm notice 1.8kB lib/rules/declaration-colon-space-before/index.js npm notice 1.2kB lib/rules/declaration-colon-space-before/README.md npm notice 4.2kB lib/rules/declaration-empty-line-before/index.js npm notice 4.5kB lib/rules/declaration-empty-line-before/README.md npm notice 806B lib/rules/declaration-no-important/index.js npm notice 792B lib/rules/declaration-no-important/README.md npm notice 2.4kB lib/rules/declaration-property-unit-allowed-list/index.js npm notice 2.1kB lib/rules/declaration-property-unit-allowed-list/README.md npm notice 2.1kB lib/rules/declaration-property-unit-disallowed-list/index.js npm notice 1.4kB lib/rules/declaration-property-unit-disallowed-list/README.md npm notice 1.5kB lib/rules/declaration-property-value-allowed-list/index.js npm notice 2.3kB lib/rules/declaration-property-value-allowed-list/README.md npm notice 1.5kB lib/rules/declaration-property-value-disallowed-list/index.js npm notice 2.5kB lib/rules/declaration-property-value-disallowed-list/README.md npm notice 1.5kB lib/rules/declarationBangSpaceChecker.js npm notice 1.7kB lib/rules/declarationColonSpaceChecker.js npm notice 746B lib/rules/findMediaOperator.js npm notice 4.2kB lib/rules/font-family-name-quotes/index.js npm notice 5.0kB lib/rules/font-family-name-quotes/README.md npm notice 2.5kB lib/rules/font-family-no-duplicate-names/index.js npm notice 1.6kB lib/rules/font-family-no-duplicate-names/README.md npm notice 2.7kB lib/rules/font-family-no-missing-generic-family-keyword/index.js npm notice 1.6kB lib/rules/font-family-no-missing-generic-family-keyword/README.md npm notice 4.2kB lib/rules/font-weight-notation/index.js npm notice 2.0kB lib/rules/font-weight-notation/README.md npm notice 1.6kB lib/rules/function-allowed-list/index.js npm notice 1.1kB lib/rules/function-allowed-list/README.md npm notice 7.0kB lib/rules/function-calc-no-unspaced-operator/index.js npm notice 1.1kB lib/rules/function-calc-no-unspaced-operator/README.md npm notice 1.5kB lib/rules/function-comma-newline-after/index.js npm notice 1.9kB lib/rules/function-comma-newline-after/README.md npm notice 1.5kB lib/rules/function-comma-newline-before/index.js npm notice 2.0kB lib/rules/function-comma-newline-before/README.md npm notice 1.5kB lib/rules/function-comma-space-after/index.js npm notice 2.5kB lib/rules/function-comma-space-after/README.md npm notice 1.5kB lib/rules/function-comma-space-before/index.js npm notice 2.5kB lib/rules/function-comma-space-before/README.md npm notice 1.6kB lib/rules/function-disallowed-list/index.js npm notice 845B lib/rules/function-disallowed-list/README.md npm notice 3.0kB lib/rules/function-linear-gradient-no-nonstandard-direction/index.js npm notice 1.9kB lib/rules/function-linear-gradient-no-nonstandard-direction/README.md npm notice 3.1kB lib/rules/function-max-empty-lines/index.js npm notice 1.1kB lib/rules/function-max-empty-lines/README.md npm notice 3.0kB lib/rules/function-name-case/index.js npm notice 2.4kB lib/rules/function-name-case/README.md npm notice 6.3kB lib/rules/function-parentheses-newline-inside/index.js npm notice 2.2kB lib/rules/function-parentheses-newline-inside/README.md npm notice 4.7kB lib/rules/function-parentheses-space-inside/index.js npm notice 2.5kB lib/rules/function-parentheses-space-inside/README.md npm notice 1.2kB lib/rules/function-url-no-scheme-relative/index.js npm notice 925B lib/rules/function-url-no-scheme-relative/README.md npm notice 3.4kB lib/rules/function-url-quotes/index.js npm notice 1.9kB lib/rules/function-url-quotes/README.md npm notice 1.7kB lib/rules/function-url-scheme-allowed-list/index.js npm notice 1.7kB lib/rules/function-url-scheme-allowed-list/README.md npm notice 1.7kB lib/rules/function-url-scheme-disallowed-list/index.js npm notice 1.7kB lib/rules/function-url-scheme-disallowed-list/README.md npm notice 4.4kB lib/rules/function-whitespace-after/index.js npm notice 1.7kB lib/rules/function-whitespace-after/README.md npm notice 3.8kB lib/rules/functionCommaSpaceChecker.js npm notice 804B lib/rules/functionCommaSpaceFix.js npm notice 3.2kB lib/rules/hue-degree-notation/index.js npm notice 1.4kB lib/rules/hue-degree-notation/README.md npm notice 19.9kB lib/rules/indentation/index.js npm notice 5.7kB lib/rules/indentation/README.md npm notice 18.4kB lib/rules/index.js npm notice 919B lib/rules/keyframe-declaration-no-important/index.js npm notice 874B lib/rules/keyframe-declaration-no-important/README.md npm notice 1.2kB lib/rules/keyframes-name-pattern/index.js npm notice 686B lib/rules/keyframes-name-pattern/README.md npm notice 4.9kB lib/rules/length-zero-no-unit/index.js npm notice 1.7kB lib/rules/length-zero-no-unit/README.md npm notice 2.7kB lib/rules/linebreaks/index.js npm notice 443B lib/rules/linebreaks/README.md npm notice 5.6kB lib/rules/max-empty-lines/index.js npm notice 1.5kB lib/rules/max-empty-lines/README.md npm notice 5.5kB lib/rules/max-line-length/index.js npm notice 3.3kB lib/rules/max-line-length/README.md npm notice 3.4kB lib/rules/max-nesting-depth/index.js npm notice 5.4kB lib/rules/max-nesting-depth/README.md npm notice 2.2kB lib/rules/media-feature-colon-space-after/index.js npm notice 1.3kB lib/rules/media-feature-colon-space-after/README.md npm notice 2.2kB lib/rules/media-feature-colon-space-before/index.js npm notice 1.3kB lib/rules/media-feature-colon-space-before/README.md npm notice 2.3kB lib/rules/media-feature-name-allowed-list/index.js npm notice 1.0kB lib/rules/media-feature-name-allowed-list/README.md npm notice 2.9kB lib/rules/media-feature-name-case/index.js npm notice 1.8kB lib/rules/media-feature-name-case/README.md npm notice 2.3kB lib/rules/media-feature-name-disallowed-list/index.js npm notice 1.0kB lib/rules/media-feature-name-disallowed-list/README.md npm notice 2.6kB lib/rules/media-feature-name-no-unknown/index.js npm notice 1.6kB lib/rules/media-feature-name-no-unknown/README.md npm notice 1.3kB lib/rules/media-feature-name-no-vendor-prefix/index.js npm notice 998B lib/rules/media-feature-name-no-vendor-prefix/README.md npm notice 2.9kB lib/rules/media-feature-name-value-allowed-list/index.js npm notice 1.7kB lib/rules/media-feature-name-value-allowed-list/README.md npm notice 2.8kB lib/rules/media-feature-parentheses-space-inside/index.js npm notice 1.2kB lib/rules/media-feature-parentheses-space-inside/README.md npm notice 2.7kB lib/rules/media-feature-range-operator-space-after/index.js npm notice 1.3kB lib/rules/media-feature-range-operator-space-after/README.md npm notice 2.7kB lib/rules/media-feature-range-operator-space-before/index.js npm notice 1.3kB lib/rules/media-feature-range-operator-space-before/README.md npm notice 2.7kB lib/rules/media-query-list-comma-newline-after/index.js npm notice 2.2kB lib/rules/media-query-list-comma-newline-after/README.md npm notice 1.2kB lib/rules/media-query-list-comma-newline-before/index.js npm notice 2.0kB lib/rules/media-query-list-comma-newline-before/README.md npm notice 2.5kB lib/rules/media-query-list-comma-space-after/index.js npm notice 2.7kB lib/rules/media-query-list-comma-space-after/README.md npm notice 2.5kB lib/rules/media-query-list-comma-space-before/index.js npm notice 2.7kB lib/rules/media-query-list-comma-space-before/README.md npm notice 1.3kB lib/rules/mediaFeatureColonSpaceChecker.js npm notice 1.8kB lib/rules/mediaQueryListCommaWhitespaceChecker.js npm notice 2.3kB lib/rules/named-grid-areas-no-invalid/index.js npm notice 929B lib/rules/named-grid-areas-no-invalid/README.md npm notice 1.1kB lib/rules/named-grid-areas-no-invalid/utils/findNotContiguousOrRectangular.js npm notice 212B lib/rules/named-grid-areas-no-invalid/utils/isRectangular.js npm notice 4.4kB lib/rules/no-descending-specificity/index.js npm notice 4.6kB lib/rules/no-descending-specificity/README.md npm notice 1.7kB lib/rules/no-duplicate-at-import-rules/index.js npm notice 810B lib/rules/no-duplicate-at-import-rules/README.md npm notice 4.8kB lib/rules/no-duplicate-selectors/index.js npm notice 2.3kB lib/rules/no-duplicate-selectors/README.md npm notice 1.1kB lib/rules/no-empty-first-line/index.js npm notice 644B lib/rules/no-empty-first-line/README.md npm notice 791B lib/rules/no-empty-source/index.js npm notice 535B lib/rules/no-empty-source/README.md npm notice 5.5kB lib/rules/no-eol-whitespace/index.js npm notice 1.2kB lib/rules/no-eol-whitespace/README.md npm notice 4.5kB lib/rules/no-extra-semicolons/index.js npm notice 943B lib/rules/no-extra-semicolons/README.md npm notice 1.0kB lib/rules/no-invalid-double-slash-comments/index.js npm notice 1.2kB lib/rules/no-invalid-double-slash-comments/README.md npm notice 1.6kB lib/rules/no-invalid-position-at-import-rule/index.js npm notice 1.2kB lib/rules/no-invalid-position-at-import-rule/README.md npm notice 3.5kB lib/rules/no-irregular-whitespace/index.js npm notice 1.3kB lib/rules/no-irregular-whitespace/README.md npm notice 1.1kB lib/rules/no-missing-end-of-source-newline/index.js npm notice 599B lib/rules/no-missing-end-of-source-newline/README.md npm notice 1.7kB lib/rules/no-unknown-animations/index.js npm notice 1.4kB lib/rules/no-unknown-animations/README.md npm notice 4.3kB lib/rules/number-leading-zero/index.js npm notice 1.3kB lib/rules/number-leading-zero/README.md npm notice 2.5kB lib/rules/number-max-precision/index.js npm notice 1.9kB lib/rules/number-max-precision/README.md npm notice 3.2kB lib/rules/number-no-trailing-zeros/index.js npm notice 686B lib/rules/number-no-trailing-zeros/README.md npm notice 1.4kB lib/rules/property-allowed-list/index.js npm notice 1.4kB lib/rules/property-allowed-list/README.md npm notice 1.3kB lib/rules/property-case/index.js npm notice 2.0kB lib/rules/property-case/README.md npm notice 1.4kB lib/rules/property-disallowed-list/index.js npm notice 1.2kB lib/rules/property-disallowed-list/README.md npm notice 2.4kB lib/rules/property-no-unknown/index.js npm notice 2.6kB lib/rules/property-no-unknown/README.md npm notice 1.6kB lib/rules/property-no-vendor-prefix/index.js npm notice 1.2kB lib/rules/property-no-vendor-prefix/README.md npm notice 2.1kB lib/rules/rangeContextNodeParser.js npm notice 4.1kB lib/rules/rule-empty-line-before/index.js npm notice 4.7kB lib/rules/rule-empty-line-before/README.md npm notice 4.9kB lib/rules/selector-attribute-brackets-space-inside/index.js npm notice 1.7kB lib/rules/selector-attribute-brackets-space-inside/README.md npm notice 1.6kB lib/rules/selector-attribute-name-disallowed-list/index.js npm notice 748B lib/rules/selector-attribute-name-disallowed-list/README.md npm notice 1.6kB lib/rules/selector-attribute-operator-allowed-list/index.js npm notice 719B lib/rules/selector-attribute-operator-allowed-list/README.md npm notice 1.6kB lib/rules/selector-attribute-operator-disallowed-list/index.js npm notice 607B lib/rules/selector-attribute-operator-disallowed-list/README.md npm notice 2.8kB lib/rules/selector-attribute-operator-space-after/index.js npm notice 2.3kB lib/rules/selector-attribute-operator-space-after/README.md npm notice 2.1kB lib/rules/selector-attribute-operator-space-before/index.js npm notice 2.3kB lib/rules/selector-attribute-operator-space-before/README.md npm notice 2.3kB lib/rules/selector-attribute-quotes/index.js npm notice 1.5kB lib/rules/selector-attribute-quotes/README.md npm notice 3.2kB lib/rules/selector-class-pattern/index.js npm notice 1.7kB lib/rules/selector-class-pattern/README.md npm notice 1.7kB lib/rules/selector-combinator-allowed-list/index.js npm notice 781B lib/rules/selector-combinator-allowed-list/README.md npm notice 1.7kB lib/rules/selector-combinator-disallowed-list/index.js npm notice 787B lib/rules/selector-combinator-disallowed-list/README.md npm notice 1.4kB lib/rules/selector-combinator-space-after/index.js npm notice 1.7kB lib/rules/selector-combinator-space-after/README.md npm notice 1.4kB lib/rules/selector-combinator-space-before/index.js npm notice 1.7kB lib/rules/selector-combinator-space-before/README.md npm notice 2.2kB lib/rules/selector-descendant-combinator-no-non-space/index.js npm notice 847B lib/rules/selector-descendant-combinator-no-non-space/README.md npm notice 1.2kB lib/rules/selector-disallowed-list/index.js npm notice 930B lib/rules/selector-disallowed-list/README.md npm notice 1.6kB lib/rules/selector-id-pattern/index.js npm notice 941B lib/rules/selector-id-pattern/README.md npm notice 3.1kB lib/rules/selector-list-comma-newline-after/index.js npm notice 1.9kB lib/rules/selector-list-comma-newline-after/README.md npm notice 2.5kB lib/rules/selector-list-comma-newline-before/index.js npm notice 1.7kB lib/rules/selector-list-comma-newline-before/README.md npm notice 2.3kB lib/rules/selector-list-comma-space-after/index.js npm notice 1.9kB lib/rules/selector-list-comma-space-after/README.md npm notice 2.3kB lib/rules/selector-list-comma-space-before/index.js npm notice 1.9kB lib/rules/selector-list-comma-space-before/README.md npm notice 2.6kB lib/rules/selector-max-attribute/index.js npm notice 2.3kB lib/rules/selector-max-attribute/README.md npm notice 2.1kB lib/rules/selector-max-class/index.js npm notice 1.3kB lib/rules/selector-max-class/README.md npm notice 1.9kB lib/rules/selector-max-combinators/index.js npm notice 1.1kB lib/rules/selector-max-combinators/README.md npm notice 2.4kB lib/rules/selector-max-compound-selectors/index.js npm notice 1.8kB lib/rules/selector-max-compound-selectors/README.md npm notice 1.9kB lib/rules/selector-max-empty-lines/index.js npm notice 1.1kB lib/rules/selector-max-empty-lines/README.md npm notice 2.7kB lib/rules/selector-max-id/index.js npm notice 2.0kB lib/rules/selector-max-id/README.md npm notice 2.4kB lib/rules/selector-max-pseudo-class/index.js npm notice 1.2kB lib/rules/selector-max-pseudo-class/README.md npm notice 5.6kB lib/rules/selector-max-specificity/index.js npm notice 2.2kB lib/rules/selector-max-specificity/README.md npm notice 4.8kB lib/rules/selector-max-type/index.js npm notice 2.8kB lib/rules/selector-max-type/README.md npm notice 2.3kB lib/rules/selector-max-universal/index.js npm notice 1.4kB lib/rules/selector-max-universal/README.md npm notice 1.3kB lib/rules/selector-nested-pattern/index.js npm notice 1.2kB lib/rules/selector-nested-pattern/README.md npm notice 3.0kB lib/rules/selector-no-qualifying-type/index.js npm notice 1.5kB lib/rules/selector-no-qualifying-type/README.md npm notice 1.8kB lib/rules/selector-no-vendor-prefix/index.js npm notice 1.2kB lib/rules/selector-no-vendor-prefix/README.md npm notice 1.7kB lib/rules/selector-pseudo-class-allowed-list/index.js npm notice 1.0kB lib/rules/selector-pseudo-class-allowed-list/README.md npm notice 2.3kB lib/rules/selector-pseudo-class-case/index.js npm notice 1.4kB lib/rules/selector-pseudo-class-case/README.md npm notice 1.7kB lib/rules/selector-pseudo-class-disallowed-list/index.js npm notice 1.0kB lib/rules/selector-pseudo-class-disallowed-list/README.md npm notice 3.8kB lib/rules/selector-pseudo-class-no-unknown/index.js npm notice 1.2kB lib/rules/selector-pseudo-class-no-unknown/README.md npm notice 3.6kB lib/rules/selector-pseudo-class-parentheses-space-inside/index.js npm notice 1.3kB lib/rules/selector-pseudo-class-parentheses-space-inside/README.md npm notice 1.7kB lib/rules/selector-pseudo-element-allowed-list/index.js npm notice 902B lib/rules/selector-pseudo-element-allowed-list/README.md npm notice 2.1kB lib/rules/selector-pseudo-element-case/index.js npm notice 1.6kB lib/rules/selector-pseudo-element-case/README.md npm notice 2.4kB lib/rules/selector-pseudo-element-colon-notation/index.js npm notice 2.6kB lib/rules/selector-pseudo-element-colon-notation/README.md npm notice 1.7kB lib/rules/selector-pseudo-element-disallowed-list/index.js npm notice 908B lib/rules/selector-pseudo-element-disallowed-list/README.md npm notice 2.2kB lib/rules/selector-pseudo-element-no-unknown/index.js npm notice 1.2kB lib/rules/selector-pseudo-element-no-unknown/README.md npm notice 2.7kB lib/rules/selector-type-case/index.js npm notice 1.2kB lib/rules/selector-type-case/README.md npm notice 3.0kB lib/rules/selector-type-no-unknown/index.js npm notice 1.9kB lib/rules/selector-type-no-unknown/README.md npm notice 1.8kB lib/rules/selectorAttributeOperatorSpaceChecker.js npm notice 2.1kB lib/rules/selectorCombinatorSpaceChecker.js npm notice 894B lib/rules/selectorListCommaWhitespaceChecker.js npm notice 3.6kB lib/rules/shorthand-property-no-redundant-values/index.js npm notice 1.3kB lib/rules/shorthand-property-no-redundant-values/README.md npm notice 3.0kB lib/rules/string-no-newline/index.js npm notice 1.3kB lib/rules/string-no-newline/README.md npm notice 5.8kB lib/rules/string-quotes/index.js npm notice 2.3kB lib/rules/string-quotes/README.md npm notice 3.4kB lib/rules/time-min-milliseconds/index.js npm notice 1.5kB lib/rules/time-min-milliseconds/README.md npm notice 1.1kB lib/rules/unicode-bom/index.js npm notice 523B lib/rules/unicode-bom/README.md npm notice 2.3kB lib/rules/unit-allowed-list/index.js npm notice 1.6kB lib/rules/unit-allowed-list/README.md npm notice 2.8kB lib/rules/unit-case/index.js npm notice 1.4kB lib/rules/unit-case/README.md npm notice 3.6kB lib/rules/unit-disallowed-list/index.js npm notice 2.4kB lib/rules/unit-disallowed-list/README.md npm notice 4.0kB lib/rules/unit-no-unknown/index.js npm notice 1.9kB lib/rules/unit-no-unknown/README.md npm notice 6.3kB lib/rules/value-keyword-case/index.js npm notice 4.0kB lib/rules/value-keyword-case/README.md npm notice 3.0kB lib/rules/value-list-comma-newline-after/index.js npm notice 1.8kB lib/rules/value-list-comma-newline-after/README.md npm notice 1.2kB lib/rules/value-list-comma-newline-before/index.js npm notice 1.7kB lib/rules/value-list-comma-newline-before/README.md npm notice 2.5kB lib/rules/value-list-comma-space-after/index.js npm notice 2.3kB lib/rules/value-list-comma-space-after/README.md npm notice 2.5kB lib/rules/value-list-comma-space-before/index.js npm notice 2.3kB lib/rules/value-list-comma-space-before/README.md npm notice 1.8kB lib/rules/value-list-max-empty-lines/index.js npm notice 1.6kB lib/rules/value-list-max-empty-lines/README.md npm notice 2.3kB lib/rules/value-no-vendor-prefix/index.js npm notice 1.3kB lib/rules/value-no-vendor-prefix/README.md npm notice 1.2kB lib/rules/valueListCommaWhitespaceChecker.js npm notice 8.8kB lib/standalone.js npm notice 597B lib/utils/addEmptyLineAfter.js npm notice 481B lib/utils/addEmptyLineBefore.js npm notice 330B lib/utils/arrayEqual.js npm notice 285B lib/utils/atRuleParamIndex.js npm notice 675B lib/utils/beforeBlockString.js npm notice 717B lib/utils/blockString.js npm notice 178B lib/utils/blurComments.js npm notice 1.6kB lib/utils/blurFunctionArguments.js npm notice 175B lib/utils/blurInterpolation.js npm notice 1.7kB lib/utils/checkAgainstRule.js npm notice 2.3kB lib/utils/checkInvalidCLIOptions.js npm notice 281B lib/utils/configurationError.js npm notice 1.2kB lib/utils/containsString.js npm notice 718B lib/utils/declarationValueIndex.js npm notice 1.8kB lib/utils/eachDeclarationBlock.js npm notice 1.9kB lib/utils/FileCache.js npm notice 703B lib/utils/filterFilePaths.js npm notice 1.5kB lib/utils/findAnimationName.js npm notice 523B lib/utils/findAtRuleContext.js npm notice 3.0kB lib/utils/findFontFamily.js npm notice 1.4kB lib/utils/findListStyleType.js npm notice 1.1kB lib/utils/functionArgumentsSearch.js npm notice 230B lib/utils/getAtRuleParams.js npm notice 1.7kB lib/utils/getCacheFile.js npm notice 228B lib/utils/getDeclarationValue.js npm notice 991B lib/utils/getFileIgnorer.js npm notice 384B lib/utils/getFormatterOptionsText.js npm notice 777B lib/utils/getModulePath.js npm notice 713B lib/utils/getNextNonSharedLineCommentNode.js npm notice 212B lib/utils/getOsEol.js npm notice 842B lib/utils/getPreviousNonSharedLineCommentNode.js npm notice 242B lib/utils/getRuleSelector.js npm notice 923B lib/utils/getSchemeFromUrl.js npm notice 942B lib/utils/getUnitFromValueNode.js npm notice 344B lib/utils/hasBlock.js npm notice 394B lib/utils/hasEmptyBlock.js npm notice 276B lib/utils/hasEmptyLine.js npm notice 245B lib/utils/hash.js npm notice 683B lib/utils/hasInterpolation.js npm notice 238B lib/utils/hasLessInterpolation.js npm notice 190B lib/utils/hasPsvInterpolation.js npm notice 174B lib/utils/hasScssInterpolation.js npm notice 286B lib/utils/hasTplInterpolation.js npm notice 321B lib/utils/isAfterComment.js npm notice 488B lib/utils/isAfterSingleLineComment.js npm notice 598B lib/utils/isAfterStandardPropertyDeclaration.js npm notice 7.3kB lib/utils/isAutoprefixable.js npm notice 566B lib/utils/isBlocklessAtRuleAfterBlocklessAtRule.js npm notice 621B lib/utils/isBlocklessAtRuleAfterSameNameBlocklessAtRule.js npm notice 796B lib/utils/isContextFunctionalPseudoClass.js npm notice 389B lib/utils/isCounterIncrementCustomIdentValue.js npm notice 385B lib/utils/isCounterResetCustomIdentValue.js npm notice 862B lib/utils/isCustomElement.js npm notice 199B lib/utils/isCustomMediaQuery.js npm notice 194B lib/utils/isCustomProperty.js npm notice 198B lib/utils/isCustomSelector.js npm notice 1.4kB lib/utils/isFirstNested.js npm notice 333B lib/utils/isFirstNodeOfRoot.js npm notice 347B lib/utils/isKeyframeRule.js npm notice 399B lib/utils/isKeyframeSelector.js npm notice 320B lib/utils/isLessVariable.js npm notice 406B lib/utils/isMathFunction.js npm notice 184B lib/utils/isNonNegativeInteger.js npm notice 331B lib/utils/isNumbery.js npm notice 410B lib/utils/isOnlyWhitespace.js npm notice 331B lib/utils/isPathNotFoundError.js npm notice 333B lib/utils/isRangeContextMediaFeature.js npm notice 422B lib/utils/isScssVariable.js npm notice 1.4kB lib/utils/isSharedLineComment.js npm notice 231B lib/utils/isSingleLineString.js npm notice 730B lib/utils/isStandardSyntaxAtRule.js npm notice 817B lib/utils/isStandardSyntaxCombinator.js npm notice 392B lib/utils/isStandardSyntaxComment.js npm notice 1.6kB lib/utils/isStandardSyntaxDeclaration.js npm notice 308B lib/utils/isStandardSyntaxFunction.js npm notice 359B lib/utils/isStandardSyntaxMathFunction.js npm notice 533B lib/utils/isStandardSyntaxMediaFeature.js npm notice 288B lib/utils/isStandardSyntaxMediaFeatureName.js npm notice 670B lib/utils/isStandardSyntaxProperty.js npm notice 501B lib/utils/isStandardSyntaxRule.js npm notice 1.1kB lib/utils/isStandardSyntaxSelector.js npm notice 1.5kB lib/utils/isStandardSyntaxTypeSelector.js npm notice 1.4kB lib/utils/isStandardSyntaxUrl.js npm notice 1.0kB lib/utils/isStandardSyntaxValue.js npm notice 609B lib/utils/isValidFontSize.js npm notice 243B lib/utils/isValidHex.js npm notice 223B lib/utils/isVariable.js npm notice 203B lib/utils/isWhitespace.js npm notice 2.5kB lib/utils/matchesStringOrRegExp.js npm notice 451B lib/utils/nextNonCommentNode.js npm notice 1.2kB lib/utils/nodeContextLookup.js npm notice 400B lib/utils/noFilesFoundError.js npm notice 565B lib/utils/optionsMatches.js npm notice 516B lib/utils/parseSelector.js npm notice 471B lib/utils/putIfAbsent.js npm notice 312B lib/utils/rawNodeString.js npm notice 387B lib/utils/removeEmptyLinesAfter.js npm notice 364B lib/utils/removeEmptyLinesBefore.js npm notice 2.8kB lib/utils/report.js npm notice 1.1kB lib/utils/ruleMessages.js npm notice 380B lib/utils/setAtRuleParams.js npm notice 385B lib/utils/setDeclarationValue.js npm notice 504B lib/utils/transformSelector.js npm notice 1.1kB lib/utils/typeGuards.js npm notice 920B lib/utils/validateObjectWithArrayProps.js npm notice 4.5kB lib/utils/validateOptions.js npm notice 891B lib/utils/validateTypes.js npm notice 973B lib/utils/vendor.js npm notice 9.6kB lib/utils/whitespaceChecker.js npm notice 2.1kB lib/validateDisableSettings.js npm notice 336B lib/writeOutputFile.js npm notice 5.1kB package.json npm notice 10.4kB types/stylelint/index.d.ts npm notice === Tarball Details === npm notice name: stylelint npm notice version: 13.13.1 npm notice filename: stylelint-13.13.1.tgz npm notice package size: 259.9 kB npm notice unpacked size: 1.4 MB npm notice shasum: 1e1e8810a44cd368780debfa9251cebc636754da npm notice integrity: sha512-DNyvyQ8dvvOua[...]vYfwf4cpy8Wjg== npm notice total files: 572 ```

@ntwb
Copy link
Member

ntwb commented Oct 20, 2021

🎉 Done

It's pushed the 14.0.0-0 tag to this PR, that wasn't expected


The inclusion of __tests__ in that list doesn't look right. However, the npm publish --dry-run looks fine so I think we're good:

These were not published:

@ntwb
Copy link
Member

ntwb commented Oct 20, 2021

I've created stylelint-scss/stylelint-config-standard-scss@main...ntwb:patch-1 to add:

  "peerDependencies": {
-    "stylelint": "^10.1.0 || ^11.0.0 || ^12.0.0 || ^13.0.0"
+    "stylelint": "^10.1.0 || ^11.0.0 || ^12.0.0 || ^13.0.0" || ^14.0.0"
  },

Edit: Duplicate of https://github.com/stylelint-scss/stylelint-config-standard-scss/pull/1/files

Commented: https://github.com/stylelint-scss/stylelint-config-standard-scss/pull/1/files#r732749906

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

Edit: Duplicate of https://github.com/stylelint-scss/stylelint-config-standard-scss/pull/1/files

Yep, you'll want to use that branch.

I think I'll publish prereleases for all the packages so that we can be confident everything works together.

@ntwb
Copy link
Member

ntwb commented Oct 20, 2021

Thanks @jeddy3, I think this will be super helpful, I'm not able to get it working in VS Code, details in my comment in that repo, cli is working fine for me though.

Being able to verify everything working together now, rather than after release would be great.

It's midnight here and I'm calling it a day, struggling to focus

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

Following on #5604 (comment).

I thought maybe the problem was how I configured the files glob, so I tried:

{
  "rules": {
    "block-no-empty": null
  },
  "overrides": [
    {
      "files": ["*.scss"],
      "customSyntax": "postcss-scss",
      "rules": {
        "block-no-empty": true
      }
    }
  ]
}

i.e. "files": ["*.scss"] instead of "files": ["**/*.scss"]

But the same issue. Have I miss understood how the files glob works? I was expecting "files": ["*.scss"] to match all files with a scss extension.

@hudochenkov
Copy link
Member

I believe glob "*.scss" would only match .scss files in a current folder:

An asterisk (*) — matches everything except slashes (path separators)

https://github.com/mrmlnc/fast-glob#basic-syntax

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

I believe glob "*.scss" would only match .scss files in a current folder:

That makes sense.

The behaviour is in line with the docs (which I probably should have read first!):

The patterns are applied against the file path relative to the directory of the config file. For example, if your config file has the path /Users/person/workspace/any-project/.stylelintrc.js and the file you want to lint has the path /Users/person/workspace/any-project/components/card.css, then the pattern provided in .stylelintrc.js will be executed against the relative path components/card.css.

I got my local test code to work by setting the glob to ../**/*.scss when the config is in a sub folder.

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

I've released prerelease versions of all the packages in the release sequence under the next tag, e.g. npm i --save-dev stylelint@next. Hopefully, they'll make testing the VS Code extension easier.

Please give them a go in your projects.

If things look good with the VS Code extension. I can release tomorrow.

@hudochenkov
Copy link
Member

We could improve in a separate PR and show file path in syntax warning:

Screen Shot 2021-10-20 at 21 48 00

Other than that CSS-in-JS in TypeScript files are working as before using @stylelint/postcss-css-in-js syntax.

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 20, 2021

We could improve in a separate PR and show file path in syntax warning:

SGTM. We can merge into v14.

hudochenkov and others added 3 commits October 21, 2021 05:29
* Show more info in missing customSyntax warning

* Change markdown syntax

* Update lib/getPostcssResult.js

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3
Copy link
Member Author

jeddy3 commented Oct 21, 2021

Going to start the release at 2pm UK time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet