Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cli.test.js #5266

Merged
merged 1 commit into from Apr 30, 2021
Merged

Refactor cli.test.js #5266

merged 1 commit into from Apr 30, 2021

Conversation

ybiquitous
Copy link
Member

This refactoring aims to make the code more readable by reducing duplication.

E.g.

-replaceBackslashes(path.join(fixturesPath, 'config-block-no-empty.json')),
+fixturesPath('config-block-no-empty.json'),

Which issue, if any, is this issue related to?

Preparation for #5265

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

This refactoring aims to make the code more readable by reducing duplication.

E.g.

```diff
-replaceBackslashes(path.join(fixturesPath, 'config-block-no-empty.json')),
+fixturesPath('config-block-no-empty.json'),
```
@ybiquitous ybiquitous marked this pull request as ready for review April 30, 2021 06:21
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeddy3 jeddy3 merged commit 361c070 into master Apr 30, 2021
@jeddy3 jeddy3 deleted the refactor-cli-test branch April 30, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants