Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types/browserslist and update browserslist #5182

Merged
merged 1 commit into from Mar 3, 2021

Conversation

ybiquitous
Copy link
Member

@types/browserslist@4.15.0 has been deprecated because browserslist@4.16.3 provides its own type definitions.
So, this change removes @types/browserslist and updates browserslist to the latest version.

I execute the following commands to update package.json and package-lock.json:

npm rm @types/browserslist
npm up browserslist

See below:

Which issue, if any, is this issue related to?

Close #5118

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

`@types/browserslist@4.15.0` has been deprecated because `browserslist@4.16.3` provides its own type definitions.
So, this change removes `@types/browserslist` and updates `browserslist` to the latest version.

I execute the following commands to update `package.json` and `package-lock.json`:

```shell
npm rm @types/browserslist
npm up browserslist
```

See below:
- https://www.npmjs.com/package/@types/browserslist/v/4.15.0
- https://github.com/browserslist/browserslist/blob/4.16.3/index.d.ts

Close #5118
"integrity": "sha512-BSVRLCeG3Xt/j/1cCGj1019Wbty0H+Yvu2AOuZSuoaUWn3RatbL33Cxk+Q4jRMRAbOm0p7SLravLjpnT6s0vzQ==",
"version": "4.16.3",
"resolved": "https://registry.npmjs.org/browserslist/-/browserslist-4.16.3.tgz",
"integrity": "sha512-vIyhWmIkULaq04Gt93txdh+j02yX/JzlyhLYbV3YQCn/zvES3JnY7TifHHvvr1w5hTDluNKMkV05cs4vy8Q7sw==",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeddy3 jeddy3 merged commit c800dc4 into master Mar 3, 2021
@jeddy3 jeddy3 deleted the remove-@types/browserslist branch March 3, 2021 12:35
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Development

Successfully merging this pull request may close these issues.

None yet

3 participants