Add selector-attribute-name-disallowed-list #4992
Conversation
|
I'll try to fix linting and test errors. |
…rletsin/stylelint into selector-attribute-name-disallowed-list
There was a problem hiding this comment.
@rletsin Thanks. It's looks great so far!
In my original proposal, I should have said use both the:
rules as a blueprints; taking the AST traversal from selector-attribute-operator-disallowed-list and the options from media-feature-name-disallowed-list. As this rule targets names, rather than operators, it'll need to accept regexes like the media-feature-name-disallowed-list rule does.
Can you update the options, docs and tests so they are more aligned with media-feature-name-disallowed-list rule, please?
docs/user-guide/rules/list.md
Outdated
| @@ -173,6 +173,7 @@ Grouped first by the following categories and then by the [_thing_](http://apps. | |||
| - [`selector-attribute-operator-blacklist`](../../../lib/rules/selector-attribute-operator-blacklist/README.md): Specify a list of disallowed attribute operators. **(deprecated)** | |||
| - [`selector-attribute-operator-disallowed-list`](../../../lib/rules/selector-attribute-operator-disallowed-list/README.md): Specify a list of disallowed attribute operators. | |||
| - [`selector-attribute-operator-whitelist`](../../../lib/rules/selector-attribute-operator-whitelist/README.md): Specify a list of allowed attribute operators. **(deprecated)** | |||
| - [`selector-attribute-name-disallowed-list`](../../../lib/rules/selector-attribute-name-disallowed-list/README.md): Specify a list of disallowed attribute names. | |||
There was a problem hiding this comment.
Let's order this alphabetically, i.e. put it before the operator rules.
lib/rules/index.js
Outdated
| @@ -274,6 +274,9 @@ const rules = { | |||
| 'selector-attribute-operator-whitelist': importLazy(() => | |||
| require('./selector-attribute-operator-whitelist'), | |||
| )(), | |||
| 'selector-attribute-name-disallowed-list': importLazy(() => | |||
There was a problem hiding this comment.
Let's order this alphabetically, i.e. put it before the operator rules.
jeddy3
changed the title
|
@jeddy3 Thanks for your suggestions! |
|
Changelog:
|
Solution for Issue #4915
I think no, it's self-explanatory.