Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isKeyframeRule.test.js that use callbacks #4922

Merged
merged 1 commit into from Sep 9, 2020
Merged

Fix isKeyframeRule.test.js that use callbacks #4922

merged 1 commit into from Sep 9, 2020

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

This is a part of #4881.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

m-allanson
m-allanson approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mattxwang
mattxwang approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ybiquitous
Copy link
Member Author

Thank you for the review! 😄

@ybiquitous ybiquitous merged commit ea9b7ca into stylelint:master Sep 9, 2020
@ybiquitous ybiquitous deleted the fix-isKeyframeRule.test.js branch September 9, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ybiquitous @m-allanson @alexander-akait @mattxwang