Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DisableReportRange.unusedRule #4899

Closed
Tracked by #5205
nex3 opened this issue Aug 17, 2020 · 3 comments
Closed
Tracked by #5205

Remove DisableReportRange.unusedRule #4899

nex3 opened this issue Aug 17, 2020 · 3 comments
Labels
status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules
Milestone

Comments

@nex3
Copy link
Contributor

nex3 commented Aug 17, 2020

(Added by request in https://github.com/stylelint/stylelint/pull/4897/files#r470950362)

#4897 renames the DisableReportRange.unusedRule field to .rule, since it's used to refer to rules in multiple contexts (rather than just when they're unused). We're keeping the old field name around for the time being to ensure backwards-compatibility, but in the next major version release the old name should be removed entirely.

@jeddy3
Copy link
Member

jeddy3 commented Aug 31, 2020

but in the next major version release the old name should be removed entirely.

SGTM. I'll set the milestone to future-major.

@jeddy3 jeddy3 added this to the future-major milestone Aug 31, 2020
@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules labels Aug 31, 2020
@jeddy3 jeddy3 mentioned this issue Mar 21, 2021
30 tasks
@ybiquitous
Copy link
Member

Closed via #5345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules
Development

No branches or pull requests

4 participants