Add function-name-arguments-whitelist

[mockey-jockey]

Clearly describe the bug

Am trying to add the rule for the background-image URL should start with images

background-image: url(ssasimages/dummy.svg);

Which rule, if any, is the bug related to?

"function-url-scheme-whitelist": "/^images/",

What code is needed to reproduce the bug?

What stylelint configuration is needed to reproduce the bug?

{
  "rules": {
   "function-url-scheme-whitelist": "/^images/"
  }
}

Which version of stylelint are you using?

9.2.0

How are you running stylelint: CLI, PostCSS plugin, Node.js API?

stylelint app/styles

Does the bug relate to non-standard syntax (e.g. SCSS, Less etc.)?

"Yes, it's related to SCSS nested properties."

What did you expect to happen?

"No warnings to be flagged."

What actually happened (e.g. what warnings or errors did you get)?

"The following warnings were flagged:"

test.css
URL should starts images

[jeddy3]

@mockey-jockey Thanks for the report and for using the template.

The rule checks the scheme of the URL. From the docs:

A URL scheme consists of alphanumeric, +, -, and . characters. It can appear at the start of a URL and is followed by :.

i.e, the scheme is the thing up to the :, e.g. http:, https:, data:.

It's not the right rule for the job, but your use case is valid and I think we can add a new rule to stylelint for it.

Unless there are any objections, I think we can add a function-name-arguments-whitelist? From the spec:

The syntax starts with the name of the function immediately followed by a left parenthesis (i.e. a ) followed by the argument(s) to the notation followed by a right parenthesis. [emphasis mine]

The rule would be very similar to declaration-property-value-whitelist but would target function name and arguments rather than properties and values.

[mockey-jockey]

Thanks, @jeddy3 sounds good. Please let me know once done.

[jeddy3]

As there are no objections to this rule, I'll label it up as good-to-go.

• Name: function-name-arguments-whitelist
• Primary option: object: { "unprefixed-function-name": ["string", "/regex/", /regex/] }
• Secondary options: None
• Message: Unexpected arguments "${arguments}" for function "${function}"
• Description: "Specify a whitelist of allowed name and arguments pairs for functions."
• Extended description: None
• Section: "Limit language features" -> "Function"

Please let me know once done.

I've labelled the issue as ready to implement. Please consider contributing if you have time, @mockey-jockey. stylelint is an open-source volunteer project, and it's unlikely the rule will be added unless you contribute it yourself.

There are steps on how to add a new rule in the Developer guide. I suggest using declaration-property-value-whitelist as a blueprint, and then using postcss-value-parser to find and check functions within values.

[mockey-jockey]

hey Richard Hallows, I would like to create Draft PR, But i could not push the code facing this issue [image: image.png] did i missed something? can u pls help me on this thanks Mani Tamilarasan

…

On Sun, May 10, 2020 at 9:11 PM Richard Hallows ***@***.***> wrote: As there are no objections to this rule, I'll label it up as good-to-go. - Name: function-name-arguments-whitelist - Primary option: object: { "unprefixed-function-name": ["string", "/regex/", /regex/] } - Secondary options: None - Message: Unexpected arguments "${arguments}" for function "${function}" - Description: "Specify a whitelist of allowed name and arguments pairs for functions." - Extended description: None - Section: "Limit language features" -> "Function" <https://stylelint.io/user-guide/rules/list#function-1> Please let me know once done. I've labelled the issue as ready to implement. Please consider contributing <https://stylelint.io/contributing> if you have time, @mockey-jockey <https://github.com/mockey-jockey>. stylelint is an open-source volunteer project, and it's unlikely the rule will be added unless you contribute it yourself. There are steps on how to add a new rule <https://stylelint.io/developer-guide/rules#add-a-rule> in the Developer guide. I suggest using declaration-property-value-whitelist <https://stylelint.io/user-guide/rules/declaration-property-value-whitelist> as a blueprint, and then using postcss-value-parser to find and check functions within values. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4727 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIWJGUW33HB76FOGR4US76TRQ3DLPANCNFSM4MTXVGWQ> .

-- **The content of this e-mail is confidential and is intended solely for the use of the individual or entity to whom it is addressed. If you have received this e-mail by mistake, please reply to this e-mail and follow with its deletion. If you are not the intended recipient, please note that it shall be considered unlawful to copy, forward or in any manner reveal the contents of this e-mail or any part thereof to anyone. Although Freshworks has taken reasonable precautions to ensure no malware is present in this e-mail, Freshworks cannot accept responsibility for any loss or damage arising from the use of this e-mail or attachments.**

[hudochenkov]

@mockey-jockey you need to fork repository, and push to your fork. Then create a draft PR to this repository.

[mockey-jockey]

#4816 am created draft PR, could some help me to am going correct path or not. sorry am new to open source contributor that's what little bit worried how am doing good or not like that

[jeddy3]

It was decided in #4816 that this use case is best handled in a userland plugin.

Closing the issue.