Refactor CLI options definition #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to prepare for type-checking `cli.js` and does NOT type-check actually. - Camelize option names for type-checking. - Add missing `type` for some options. - Sort options alphabetically for readability. - Add a unit test for the definition (A system test is too much for this purpose). See <#4504 (comment)> for details.
ybiquitous
commented
Jan 9, 2020
| }, | ||
| 'no-color': { |
There was a problem hiding this comment.
no-color is unneeded so removed (color is enough).
See the test.
fanich37
reviewed
Jan 9, 2020
hudochenkov
reviewed
Jan 9, 2020
hudochenkov
reviewed
Jan 10, 2020
hudochenkov
approved these changes
Jan 11, 2020
fanich37
reviewed
Jan 11, 2020
fanich37
approved these changes
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to prepare for type-checking
cli.jsand does NOT type-check actually (I will do it on another PR).typefor some options.See #4504 (comment) for details.