Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict warnings count check #4231

Merged
merged 2 commits into from Sep 15, 2019
Merged

Enable strict warnings count check #4231

merged 2 commits into from Sep 15, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Aug 30, 2019

Which issue, if any, is this issue related to?

enables strict warnings count check

Is there anything in the PR that needs further explanation?

nothing

@vankop vankop added the pr: blocked is blocked by another issue or pr label Aug 30, 2019
@hudochenkov hudochenkov mentioned this pull request Sep 4, 2019
Closed
@vankop
Copy link
Member Author

vankop commented Sep 5, 2019 •
edited

blockers

@vankop vankop changed the title WIP: enable strict warnings count check Enable strict warnings count check Sep 5, 2019
@vankop vankop removed the pr: blocked is blocked by another issue or pr label Sep 15, 2019
@vankop
Copy link
Member Author

vankop commented Sep 15, 2019

So.. this is ready to merge 🚀

hudochenkov
hudochenkov approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More confidence!

@hudochenkov hudochenkov merged commit 0e3f4e2 into master Sep 15, 2019
@hudochenkov hudochenkov deleted the enable-strict-warnings-check branch September 15, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vankop @hudochenkov @ntwb