Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Needless Disables with Rule Errors and Warnings #4076

Closed
geekox86 opened this issue May 10, 2019 · 3 comments · Fixed by #4151
Closed

Report Needless Disables with Rule Errors and Warnings #4076

geekox86 opened this issue May 10, 2019 · 3 comments · Fixed by #4151
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules

Comments

@geekox86
Copy link

What is the problem you're trying to solve?

Currently, I have to run stylelint twice to get all errors and warnings that I need: once with --report-needless-disables and another time without it. I should only need to run it once for both.

What solution would you like to see?

I would like to change the behavior of --report-needless-disables so that such needless disables get reported with rule errors/warnings in one shot.
@hudochenkov
Copy link
Member

Thanks for the report and for using the template.

Yeah, it does make sense. Would you like to contribute this change?

@hudochenkov hudochenkov added good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules labels May 30, 2019
@hudochenkov hudochenkov mentioned this issue Jun 10, 2019
Closed
@maxmilton
Copy link

This one caught me off guard. I expected it to work the same as ESLint's --report-unused-disable-directives, where it adds extra errors into the regular output. I'm embarrassed to say, I had a few projects essentially not being linting for a month because of this issue 😅

I wonder how many other projects made the same assumption and haven't realised yet 🤔

thibaudcolas added a commit to thibaudcolas/stylelint that referenced this issue Jul 16, 2019
@thibaudcolas
Stop skipping linting when --report-needless-disables is used. Fix st…
295c361 
…ylelint#4076
@thibaudcolas thibaudcolas mentioned this issue Jul 16, 2019
Merged
@thibaudcolas
Copy link
Member

thibaudcolas commented Jul 16, 2019 •
edited

I was also expecting this flag to work like ESLint’s equivalent, and was very close to start using it on all of my projects as if it was 😄. Here is a PR to address this: #4151

hudochenkov pushed a commit that referenced this issue Jul 31, 2019
@thibaudcolas @hudochenkov
Stop skipping linting when --report-needless-disables is used. Fix #4076
2c43e45 
 (#4151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules
Milestone
No milestone
4 participants
@hudochenkov @thibaudcolas @geekox86 @maxmilton