Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jison-gho dependency #3915

Merged
merged 2 commits into from Jan 19, 2019
Merged

Remove jison-gho dependency #3915

merged 2 commits into from Jan 19, 2019

Conversation

hudochenkov
Copy link
Member

@hudochenkov hudochenkov commented Jan 18, 2019 •
edited by jeddy3

Which issue, if any, is this issue related to?

Closes #3913
Closes #3910.

Is there anything in the PR that needs further explanation?

Using the same strategy as in postcss-calc — compile parser and use the compiled version rather runtime.

@jeddy3 about your request for size-limit: I would rather do it in a separate PR.

@jeddy3
Copy link
Member

jeddy3 commented Jan 18, 2019

@jeddy3 about your request for size-limit: I would rather do it in a separate PR.

SGTM.

@jeddy3
Copy link
Member

jeddy3 commented Jan 18, 2019

Is the coverage decrease just an artefact of this refactor, or is it a genuine issue?

@hudochenkov
Copy link
Member Author

Now we have a new big JS file, which was included in coverage in this PR. I've excluded it.

jeddy3
jeddy3 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ota-meshi
ota-meshi approved these changes Jan 19, 2019
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeddy3 jeddy3 merged commit d896a74 into master Jan 19, 2019
@jeddy3 jeddy3 deleted the fix-jison branch January 19, 2019 09:22
@jeddy3
Copy link
Member

jeddy3 commented Jan 19, 2019

  • Fixed: "fatal: Not a git repository" error (#3915).
  • Fixed: unintended increase in package size (#3915).

@billyjanitsch
Copy link

Thanks! ❤

@ccheney ccheney mentioned this pull request Jan 25, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hudochenkov @jeddy3 @billyjanitsch @ota-meshi