Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file-entry-cache to avoid the deprecated warning #3903

Merged
merged 1 commit into from Jan 18, 2019
Merged

Update file-entry-cache to avoid the deprecated warning #3903

merged 1 commit into from Jan 18, 2019

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented Jan 17, 2019 •
edited by jeddy3

Which issue, if any, is this issue related to?

Closes #3877

Update file-entry-cache to avoid the deprecated warning

Is there anything in the PR that needs further explanation?

Just as the #3786 and #3779, the only thing to do is update the standalone-cache.test.js. Just use the parse method from the flatted which is used by file-entry-cache to create the cache to parse the content, then tests can pass.

@Teamop
Copy link
Contributor Author

Teamop commented Jan 17, 2019 •
edited

The fail test case is not related to this change, it's related with the 005 test case

jeddy3
jeddy3 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Teamop Thank you for your first-time contribution.

I'm happy to see this go in because it means we can update our dependency.

However, am I right in thinking we're still testing an implementation detail of file-entry-cache? As such, I think we can leave #3786 open.

@hudochenkov
Copy link
Member

@Teamop thank you!

However, am I right in thinking we're still testing an implementation detail of file-entry-cache? As such, I think we can leave #3786 open.

Correct.

@hudochenkov hudochenkov merged commit 127fef7 into stylelint:master Jan 18, 2019
@Teamop Teamop deleted the fix-flatted branch December 23, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Teamop @hudochenkov @jeddy3