Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to font-weight-notation #3158

Closed
hiroppy opened this issue Feb 7, 2018 · 4 comments · Fixed by #6347
Closed

Add autofix to font-weight-notation #3158

hiroppy opened this issue Feb 7, 2018 · 4 comments · Fixed by #6347
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: new autofix a new autofix for an existing rule

Comments

@hiroppy
Copy link
Member

hiroppy commented Feb 7, 2018

I read https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#adding-an-option-to-an-existing-rule and write this issue.

I already have written code.
see hiroppy@2977230

Details

numeric

a { font-weight: normal; } -> a { font-weight: 400; }
a { font: italic bold 20px; } -> a { font: italic 700 20px; }

named-where-possible

a { font-weight: 400; } -> a { font-weight: normal; }
a { font: italic 700 20px; } -> a { font: italic bold 20px; }

If this request is accepted, I will submit PR :)

@alexander-akait
Copy link
Member

@abouthiroppy PR welcome!

@alexander-akait alexander-akait added type: enhancement a new feature that isn't related to rules good first issue is good for newcomers labels Feb 7, 2018
@jeddy3 jeddy3 added the status: ready to implement is ready to be worked on by someone label Feb 7, 2018
@jeddy3 jeddy3 changed the title Enable fix option for font-weight-notation Add --fix support to font-weight-notation Feb 7, 2018
@jeddy3 jeddy3 changed the title Add --fix support to font-weight-notation Add autofix to font-weight-notation May 16, 2018
@jeddy3 jeddy3 added type: new autofix a new autofix for an existing rule and removed type: enhancement a new feature that isn't related to rules labels May 16, 2018
@jeddy3
Copy link
Member

jeddy3 commented Mar 8, 2022

Fixing #3855 (comment) is a prerequisite to adding autofix.

See also: #3159 (comment)

@FloEdelmann
Copy link
Member

@hiroppy Sorry for the ping in this old issue, but given you've already written the code for the autofix, would you fancy opening a PR?

I think @jeddy3's comment is already resolved (#3855 was closed by #6005). I don't know if that requires changes in your code though.

@ybiquitous
Copy link
Member

@FloEdelmann Thanks for the reminder. I'm going to work on this. 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: new autofix a new autofix for an existing rule
Development

Successfully merging a pull request may close this issue.

6 participants