From d9dbce2691912479b10dd6691da8cabff89bf9c7 Mon Sep 17 00:00:00 2001 From: Andrey Alexandrov Date: Thu, 9 Jan 2020 14:41:38 +0300 Subject: [PATCH] Process multiple spaces in media-feature-parentheses-space-inside (#4513) * Process multiple spaces in media (#4509) * Consider tabs as spaces --- .../__tests__/index.js | 28 +++++++++++++++++++ .../index.js | 4 +-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/lib/rules/media-feature-parentheses-space-inside/__tests__/index.js b/lib/rules/media-feature-parentheses-space-inside/__tests__/index.js index 765fd8afd1..a770af61a4 100644 --- a/lib/rules/media-feature-parentheses-space-inside/__tests__/index.js +++ b/lib/rules/media-feature-parentheses-space-inside/__tests__/index.js @@ -135,6 +135,34 @@ testRule(rule, { ], reject: [ + { + code: '@media ( min-width: 700px) {}', + fixed: '@media (min-width: 700px) {}', + message: messages.rejectedOpening, + line: 1, + column: 9, + }, + { + code: '@media (min-width: 700px ) {}', + fixed: '@media (min-width: 700px) {}', + message: messages.rejectedClosing, + line: 1, + column: 26, + }, + { + code: '@media (\t min-width: 700px) {}', + fixed: '@media (min-width: 700px) {}', + message: messages.rejectedOpening, + line: 1, + column: 9, + }, + { + code: '@media (min-width: 700px\t) {}', + fixed: '@media (min-width: 700px) {}', + message: messages.rejectedClosing, + line: 1, + column: 25, + }, { code: '@media (max-width: 300px ) {}', fixed: '@media (max-width: 300px) {}', diff --git a/lib/rules/media-feature-parentheses-space-inside/index.js b/lib/rules/media-feature-parentheses-space-inside/index.js index cfa9b988f0..001a85ddd5 100644 --- a/lib/rules/media-feature-parentheses-space-inside/index.js +++ b/lib/rules/media-feature-parentheses-space-inside/index.js @@ -39,7 +39,7 @@ function rule(expectation, options, context) { const len = valueParser.stringify(node).length; if (expectation === 'never') { - if (node.before === ' ') { + if (/[ \t]/.test(node.before)) { if (context.fix) node.before = ''; violations.push({ @@ -48,7 +48,7 @@ function rule(expectation, options, context) { }); } - if (node.after === ' ') { + if (/[ \t]/.test(node.after)) { if (context.fix) node.after = ''; violations.push({