From cecacb9d4fe3b5bae5f264efa6e60c414a0f4946 Mon Sep 17 00:00:00 2001
From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Date: Fri, 17 Jul 2020 21:36:54 +0900
Subject: [PATCH] Remove `postcss-reporter` package (#4858)

* Remove `postcss-reporter` package

This change removes the `postcss-reporter` package and reduces the dependencies.
As you see the changed `package-lock.json`, this package depends on:

- `chalk`
- `lodash`
- `log-symbols`
- `postcss`

See also https://github.com/stylelint/stylelint/issues/2454#issuecomment-622604821

We've used only the tiny utility function `getLocation()` in the package.
This function just returns an object with the `line` and `column` property in our project,
so I think we can replace it with a simple code.

https://github.com/postcss/postcss-reporter/blob/f01a601ea2cd41d626e561969d66a765b3afcb2d/lib/util.js#L4-L13

* Fix test name: `stringFormatter` -> `verboseFormatter`
---
 .../__tests__/verboseFormatter.test.js        |  2 +-
 lib/formatters/stringFormatter.js             |  7 ++---
 package-lock.json                             | 31 -------------------
 package.json                                  |  1 -
 types/postcss/index.d.ts                      |  4 ---
 5 files changed, 4 insertions(+), 41 deletions(-)

diff --git a/lib/formatters/__tests__/verboseFormatter.test.js b/lib/formatters/__tests__/verboseFormatter.test.js
index af58772952..6a98b8c4b8 100644
--- a/lib/formatters/__tests__/verboseFormatter.test.js
+++ b/lib/formatters/__tests__/verboseFormatter.test.js
@@ -4,7 +4,7 @@ const prepareFormatterOutput = require('./prepareFormatterOutput');
 const stripIndent = require('common-tags').stripIndent;
 const verboseFormatter = require('../verboseFormatter');
 
-describe('stringFormatter', () => {
+describe('verboseFormatter', () => {
 	it('outputs no warnings', () => {
 		const results = [
 			{
diff --git a/lib/formatters/stringFormatter.js b/lib/formatters/stringFormatter.js
index 7047f2b595..5896827be8 100644
--- a/lib/formatters/stringFormatter.js
+++ b/lib/formatters/stringFormatter.js
@@ -6,7 +6,6 @@ const path = require('path');
 const stringWidth = require('string-width');
 const symbols = require('log-symbols');
 const table = require('table');
-const utils = require('postcss-reporter/lib/util');
 
 const MARGIN_WIDTHS = 9;
 
@@ -134,14 +133,14 @@ function formatter(messages, source) {
 	}
 
 	const cleanedMessages = orderedMessages.map((message) => {
-		const location = utils.getLocation(message);
+		const { line, column } = message;
 		const severity = /** @type {keyof import('log-symbols')} */ (message.severity);
 		/**
 		 * @type {[string, string, string, string, string]}
 		 */
 		const row = [
-			location.line ? location.line.toString() : '',
-			location.column ? location.column.toString() : '',
+			line ? line.toString() : '',
+			column ? column.toString() : '',
 			symbols[severity]
 				? chalk[/** @type {'blue' | 'red' | 'yellow'} */ (levelColors[severity])](symbols[severity])
 				: severity,
diff --git a/package-lock.json b/package-lock.json
index ebdb4bd76b..68e48e97fe 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -7520,37 +7520,6 @@
       "resolved": "https://registry.npmjs.org/postcss-media-query-parser/-/postcss-media-query-parser-0.2.3.tgz",
       "integrity": "sha1-J7Ocb02U+Bsac7j3Y1HGCeXO8kQ="
     },
-    "postcss-reporter": {
-      "version": "6.0.1",
-      "resolved": "https://registry.npmjs.org/postcss-reporter/-/postcss-reporter-6.0.1.tgz",
-      "integrity": "sha512-LpmQjfRWyabc+fRygxZjpRxfhRf9u/fdlKf4VHG4TSPbV2XNsuISzYW1KL+1aQzx53CAppa1bKG4APIB/DOXXw==",
-      "requires": {
-        "chalk": "^2.4.1",
-        "lodash": "^4.17.11",
-        "log-symbols": "^2.2.0",
-        "postcss": "^7.0.7"
-      },
-      "dependencies": {
-        "chalk": {
-          "version": "2.4.2",
-          "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz",
-          "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==",
-          "requires": {
-            "ansi-styles": "^3.2.1",
-            "escape-string-regexp": "^1.0.5",
-            "supports-color": "^5.3.0"
-          }
-        },
-        "log-symbols": {
-          "version": "2.2.0",
-          "resolved": "https://registry.npmjs.org/log-symbols/-/log-symbols-2.2.0.tgz",
-          "integrity": "sha512-VeIAFslyIerEJLXHziedo2basKbMKtTw3vfn5IzG0XTjhAVEJyNHnL2p7vc+wBDSdQuUpNw3M2u6xb9QsAY5Eg==",
-          "requires": {
-            "chalk": "^2.0.1"
-          }
-        }
-      }
-    },
     "postcss-resolve-nested-selector": {
       "version": "0.1.1",
       "resolved": "https://registry.npmjs.org/postcss-resolve-nested-selector/-/postcss-resolve-nested-selector-0.1.1.tgz",
diff --git a/package.json b/package.json
index 286eee4dd0..40bb041b32 100644
--- a/package.json
+++ b/package.json
@@ -139,7 +139,6 @@
     "postcss-html": "^0.36.0",
     "postcss-less": "^3.1.4",
     "postcss-media-query-parser": "^0.2.3",
-    "postcss-reporter": "^6.0.1",
     "postcss-resolve-nested-selector": "^0.1.1",
     "postcss-safe-parser": "^4.0.2",
     "postcss-sass": "^0.4.4",
diff --git a/types/postcss/index.d.ts b/types/postcss/index.d.ts
index a8084ba565..5173bd4af7 100644
--- a/types/postcss/index.d.ts
+++ b/types/postcss/index.d.ts
@@ -33,10 +33,6 @@ declare module 'postcss-syntax' {
 	export = result;
 }
 
-declare module 'postcss-reporter/lib/util' {
-	export function getLocation(message: Object): { line: number; column: number; file?: string };
-}
-
 declare module 'postcss/lib/result' {
 	import { Result } from 'postcss';