Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selector-not-notation #243

Closed
jeddy3 opened this issue Mar 27, 2022 · 2 comments · Fixed by #253
Closed

Add selector-not-notation #243

jeddy3 opened this issue Mar 27, 2022 · 2 comments · Fixed by #253
Labels
status: ask to implement ask before implementing as may no longer be relevant type: enhancement a new feature that isn't related to rules

Comments

@jeddy3
Copy link
Member

jeddy3 commented Mar 27, 2022

We are introducing the selector-not-notation rule in 14.7.0.

We should add it to this config using the "complex" option as it, along with already enabled rules like color-function-notation: "modern", encourages users to write modern CSS code.
@jeddy3 jeddy3 added type: enhancement a new feature that isn't related to rules status: ask to implement ask before implementing as may no longer be relevant labels Mar 27, 2022
@jeddy3 jeddy3 added status: needs discussion triage needs further discussion and removed type: enhancement a new feature that isn't related to rules status: ask to implement ask before implementing as may no longer be relevant labels Apr 19, 2022
@jeddy3
Copy link
Member Author

jeddy3 commented Apr 19, 2022

The rule can change specificity, so we'll need to decide where to include it or not.

stylelint/stylelint#5974 (comment)

@ybiquitous
Copy link
Member

According to CanIUse.com, it seems that about 90% of users in global can use the modern notation.

So, adding the rule to this config sounds good to me. 👍🏼

@jeddy3 jeddy3 added type: enhancement a new feature that isn't related to rules status: ask to implement ask before implementing as may no longer be relevant and removed status: needs discussion triage needs further discussion labels Jun 7, 2022
This was referenced Jun 7, 2022
Closed
Merged
@jeddy3 jeddy3 mentioned this issue Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ask to implement ask before implementing as may no longer be relevant type: enhancement a new feature that isn't related to rules
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare 26.0.0 stylelint/stylelint-config-standard
2 participants
@ybiquitous @jeddy3