Removes is-ci, pinst #177
Merged
Removes is-ci, pinst #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
reviewed
Apr 11, 2021
ybiquitous
reviewed
Apr 11, 2021
This reverts commit 7188310.
|
Much smaller diff, as expected! I'll squash-and-merge on approval so the history isn't bloated. |
ybiquitous
reviewed
Apr 11, 2021
|
Thanks for the thorough review! Just tested locally one more time with a fresh install on some dummy files, and it works as intended! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the conversation in #175, to remove
is-ciandpinstin favour of using a shell script check andpreparerespectively.Tested locally with a dummy change and works as intended; only thing left is to check CI compat, but we've done this change across the stylelint org so I don't anticipate any issues!