Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #170

Merged
merged 5 commits into from Mar 5, 2021
Merged

Update deps #170

merged 5 commits into from Mar 5, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Mar 5, 2021

Which issue, if any, is this issue related to?

Closes #169
Closes #168

Is there anything in the PR that needs further explanation?

I figured this was a good time to bring the package up to date as we'll likely be putting out a new release alongside the next stylelint release.

Using the stylelint remark config caught the missing license, so I've addressed by issues in this pull request.

@jeddy3 jeddy3 mentioned this pull request Mar 5, 2021
6 tasks
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Thanks!

It seems is-ci and pinst are missing in devDependencies. No problems?

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! 👍

package.json Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3
Copy link
Member Author

jeddy3 commented Mar 5, 2021

Oh, sorry. Can we remove this old husky config?

Oops. We'll need to remove this from the main stylelint repo too as it's still in there too.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@jeddy3 jeddy3 merged commit ba2b772 into master Mar 5, 2021
@jeddy3 jeddy3 deleted the update-deps branch March 5, 2021 17:16
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing LICENSE file Migrate to @stylelint/remark-preset
2 participants