Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #19

Closed
jeddy3 opened this issue May 7, 2020 · 8 comments
Closed

Release 2.0.0 #19

jeddy3 opened this issue May 7, 2020 · 8 comments
Labels
status: needs discussion triage needs further discussion

Comments

@jeddy3
Copy link
Member

jeddy3 commented May 7, 2020

We should release 2.0.0.

I don't have access to the npm package. Please can someone with access either:

  • grant me access
  • release the package themselves
@jeddy3 jeddy3 added the status: needs discussion triage needs further discussion label May 7, 2020
@hudochenkov
Copy link
Member

@ntwb help :)

@ntwb
Copy link
Member

ntwb commented May 7, 2020

Oh, sorry, just looked and I only have access for some reason :(

Tried adding you both via the UI and ended up with “Internal Server” error

I’ll try adding you both via the CLI shortly

@ntwb
Copy link
Member

ntwb commented May 8, 2020

This doesn't work from the cli either either 😞

❯ npm owner add jeddy3 jest-preset-stylelint
This operation requires a one-time password.
Enter OTP: 002610
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/jest-preset-stylelint/-rev/5-e3a096a3a3a54692c6e3b4b9ef8c6506 - Team not found
npm ERR! 404 
npm ERR! 404  'jest-preset-stylelint@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/netweb/.npm/_logs/2020-05-08T07_33_14_400Z-debug.log

And I get the previous error mentioned above at https://www.npmjs.com/package/jest-preset-stylelint/access

Edit: I've forwarded this to npm support

@ntwb
Copy link
Member

ntwb commented May 8, 2020

I've just published 2.0.0 https://github.com/stylelint/jest-preset-stylelint/releases/tag/2.0.0

And sorry about the access, will ensure I get this fixed ASAP

Lastly, thanks for the work here everyone, greatly appreciated 🎉

@hudochenkov
Copy link
Member

stylelint-order is using this preset now. And I sent a PR to YozhikM/stylelint-a11y#54. Wanted to updated stylelint-scss, but then 114 tests are failing (due to missing message on reject, or when test has multiple warnings).

After stylelint/stylelint#4755 merged, I can migrate core repository to it.

@jeddy3
Copy link
Member Author

jeddy3 commented May 9, 2020

stylelint-order is using this preset now. And I sent a PR to YozhikM/stylelint-a11y#54.

Fantastic on both accounts.

but then 114 tests are failing (due to missing message on reject, or when test has multiple warnings).

Shall we drop an issue in their tracker? Both the missing message and multiple warnings failings are something they probably want to address as they'll increase confidence in their code.

After stylelint/stylelint#4755 merged, I can migrate core repository to it.

Merged.

@hudochenkov
Copy link
Member

Shall we drop an issue in their tracker? Both the missing message and multiple warnings failings are something they probably want to address as they'll increase confidence in their code.

Done stylelint-scss/stylelint-scss#470

@ntwb
Copy link
Member

ntwb commented May 16, 2020

So this package is under my npm netweb organisation which is why I couldn’t add anyone, npm have added you @jeddy3 to this package and I think my organisation

I’ll transfer this repo to the stylelint org later today, that should resolve this issue and we’ll be able to add all the team members correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion triage needs further discussion
Projects
None yet
Development

No branches or pull requests

3 participants