Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI configuration #144

Merged
merged 3 commits into from Sep 14, 2021
Merged

Update CI configuration #144

merged 3 commits into from Sep 14, 2021

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Sep 14, 2021 •
edited

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

@ybiquitous
Update CI configuration
ff1b284 
- Drop Node 10 from the matrix.
  - Already End-of-Life. See <https://github.com/nodejs/Release#end-of-life-releases>
- Add Node 16 to the matrix.
- Bump actions/setup-node from v1 to v2
  - Set `cache: npm` for speed-up
  - See <https://github.com/actions/setup-node#usage>
@ybiquitous ybiquitous mentioned this pull request Sep 14, 2021
Merged
5 tasks
@ybiquitous ybiquitous marked this pull request as ready for review September 14, 2021 17:21
jeddy3
jeddy3 requested changes Sep 14, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Suggested change to bump lint to LTS.

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
@ybiquitous @jeddy3
Use LTS for Lint removing matrix
3225873 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
jeddy3
jeddy3 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeddy3 jeddy3 merged commit a0b173b into master Sep 14, 2021
@jeddy3 jeddy3 deleted the update-ci-config branch September 14, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3