Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dollar-variable-pattern doesn't work inside mixins #953

Open
nickbullock opened this issue Jan 29, 2024 · 1 comment · May be fixed by #971
Open

dollar-variable-pattern doesn't work inside mixins #953

nickbullock opened this issue Jan 29, 2024 · 1 comment · May be fixed by #971
Labels
Bug 🐛 Something isn't working Enhancement ✨ New feature or request Help wanted 🙋 Help is needed

Comments

@nickbullock
Copy link

Example reproduction:

stylelintrc with kebab case regexp:

"scss/dollar-variable-pattern": "^[a-z]+(?:-[a-z]+)*$",

@myFontSize($fontSize) {
 font-size: $fontSize;
}

I believe it should report error.
@TheElegantCoding TheElegantCoding mentioned this issue Jan 31, 2024
Open
@kristerkari
Copy link
Collaborator

Thanks!

That's correct, the rule does not support function arguments.

I guess it would make sense to add support for fn arguments, since even though they're technically function arguments and not variables, the syntax is identical.

@kristerkari kristerkari added Bug 🐛 Something isn't working Enhancement ✨ New feature or request Help wanted 🙋 Help is needed labels Feb 4, 2024
@kristerkari kristerkari linked a pull request Mar 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Something isn't working Enhancement ✨ New feature or request Help wanted 🙋 Help is needed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dollar-variable-pattern: add support for functions and mixins stylelint-scss/stylelint-scss
2 participants
@kristerkari @nickbullock