Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declaration-property-value-no-unknown for SCSS nested properties. #882

Open
pamelalozano16 opened this issue Nov 1, 2023 · 3 comments
Open

Comments

@pamelalozano16
Copy link
Contributor

Rule declaration-property-value-no-unknown doesn't work for SCSS nested properties. So font-size: red; raises an error, but font: { size: red; } does not.

Demo here.

@kristerkari
Copy link
Collaborator

It's very understandable that the stylelint rules don't support the nested properties, but I was wondering if there would be a better way to add the nested property support to those rules than just duplicating them in this library.

I've been trying to avoid the mirroring of rules from the stylelint core repo, but sometimes it has been the only sensible way to make the rule work with SCSS.

@pamelalozano16
Copy link
Contributor Author

Following the discussion with @jeddy3 in the Stylelint core repository, and recognizing that discouraging the use of nested properties is not a viable option due to its significance as one of the valuable features of SCSS, I agree that we should mirror the rule in stylelint/scss and provide support for nested properties. Let me know your thoughts, @kristerkari, and if you're on board with the idea, I can take care of the implementation. :)

@kristerkari
Copy link
Collaborator

kristerkari commented Nov 27, 2023

@pamelalozano16 well, I don't like the idea of mirroring rules, but I guess that it's the only option that we have to fully support the Sass syntax.

Just remember to ping me when you have something ready 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants