Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'color-function-notation' rule is incompatible with SCSS rgb($color, $alpha) format #172

Open
WillowHayward opened this issue Jan 9, 2023 · 1 comment

Comments

@WillowHayward
Copy link

Hi all - bit of an edge case here, but seemed worth reporting.

In this repository's ruleset, the 'color-function-notation' rule is set to 'modern' (inherited from here )

However, this modifies code like rgb(black, 0.5); to rgb(black 0.5); - causing compilation errors, as SASS supports the format rgb($color, $alpha) but not rgb($color $alpha)

https://sass-lang.com/documentation/modules#rgb

@kristerkari
Copy link
Collaborator

kristerkari commented Feb 13, 2023

Thanks for reporting this @WillowHayward !

I tried adding a test case for using rgb(black, 0.5);, but at least with the latest version I can not get the test to fail. Could you check if this is still a problem with the newest release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants