Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please reopen# 3634 #3921

Closed
machineghost opened this issue Jan 17, 2023 · 7 comments
Closed

Please reopen# 3634 #3921

machineghost opened this issue Jan 17, 2023 · 7 comments

Comments

@machineghost
Copy link

Environment

npx envinfo --system --binaries --npmPackages styled-components,babel-plugin-styled-components --markdown --clipboard

Reproduction

https://codesandbox.io/s/styled-components-base-gc367

Steps to reproduce

Expected Behavior

Actual Behavior

Please reopen ticket #3634. It was closed prematurely (as evidenced by the fact that the last comment says as much, with 8 upvotes).

@quantizor
Copy link
Contributor

Hi there, someone from the Next team reached out and I gave feedback for updating their examples. I believe the issue with the new Next app directory setup is they were hacking StyleSheetManager instead of just allowing for typical rehydration after SSR

@machineghost
Copy link
Author

Well, whatever you told them, or whatever they implemented, someone got something wrong, as the issue remains for many users (at least 9, per that ticket).

@quantizor
Copy link
Contributor

Yeah I have no control over them updating their examples and repos. Everything works fine with the previous setup, so the issue is on their end not ours

@machineghost
Copy link
Author

Here's the thing: whenever library A doesn't work with library B, library A's authors always blame library B, and B's author always blames A ;)

Given that Next.js is a very major library in our ecosystem, is there any chance you (or another contributor) might review the "feedback [you gave] for updating their examples", to see if maybe something relevant was left out? Or, even better, could someone just take a few minutes to look at their implementation, to see what they misunderstood about Styled Components?

Otherwise, I fear the Next people will just say "we did what the Styled Components people told us", and the finger-pointing will result in the lack of a solution, which will ultimately lead Next.js devs to abandon Styled Components.

@quantizor
Copy link
Contributor

If it didn’t work previously until they changed their whole architecture then I’d agree with you. It’s not my obligation to support every third party library, sorry.

@machineghost
Copy link
Author

Just FYI, you're literally using Styled Components users over this; see the most recent comments (plural) on: vercel/next.js#30802 (comment)

@quantizor
Copy link
Contributor

Just FYI, you're literally using Styled Components users over this; see the most recent comments (plural) on: vercel/next.js#30802 (comment)

What do you think posting something like this accomplishes? I'm a solo maintainer on this library because everyone else has lost interest and it's taken me over a year to get v6 to the point where it's shippable.

If you want something and I'm not providing it quickly enough, CONTRIBUTE. I'm a mostly unpaid volunteer. I don't care if some 3p library breaks an existing setup that has worked for years, to be frank. That's on them. They have resources.

@styled-components styled-components locked as off-topic and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants