Bump is-prop-valid to forward translate attribute #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
approved these changes
Dec 14, 2021
|
@probablyup Done! Thank you for the review! |
|
Hey @probablyup and @ay4toh5i, This code is exactly what I need, any idea when this will be released? I've just upgraded to 5.3.3 and it's not in that version. Sorry for the tag, just really need this for my project so looking to get a rough estimate on delivery. Thanks! |
|
Temporary workaround (only with yarn), add in package.json: "resolutions": {
"styled-components/@emotion/is-prop-valid": "^1.1.0"
} |
|
Thanks, I've done this for now. |
|
@probablyup Do you have any plan to release v5.3.4 or something? |
aplavsa
pushed a commit
to aplavsa/styled-components
that referenced
this pull request
Mar 3, 2022
…3619) * Bump is-prop-valid to forward translate attribute * Add a change log entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translateattribute is html global attribute, but it is not forwarded in v5.It is added in
is-prop-valid1.0.0.https://github.com/emotion-js/emotion/blob/main/packages/is-prop-valid/CHANGELOG.md