Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Alias timing functions with 'ease' and allow percentage based easing #402

Closed
markoradak opened this issue Feb 11, 2019 · 1 comment

Comments

@markoradak
Copy link
Contributor

It might be good to have easeIn(), easeOut() and easeInOut() functions that would work pretty much the same as a timingFunctions(), but would allow us to write something like: easeOut('expo') instead of transitionFunctions('easeOutExpo'), since no other timing functions are available or make sense. It is quite a bit shorter, and we can leave current timing functions implementation along with it for backward compatibility.

On another point, the same function(s) could accept number as an argument, that would interpolate that number to a cubic bezier function. Therefore if we had easeOut(0.5) it would yield cubic-bezier(0, 0, 0.5, 1).

What are your thoughts on this?

I am happy to do a PR if you guys think it's a good idea.

@bhough
Copy link
Contributor

bhough commented Sep 20, 2020

This has been addressed in v4 which is now in beta and will be released in the coming weeks:

npm install polished@next
yarn add polished@next

bhough added a commit that referenced this issue Oct 4, 2020
* chore(library): update dependencies

Update dependencies and fix new flow error in triangle.test.js

* refactor(stripunit): fully deprecate returnUnit

Fully deprecate returnUnit functionality and refactor return.

* refactor(readablecolor): make strict mode default

Make strict mode default when passing custom colors.

* build(babel): enable bugfix: true

Enable bugfix:true in build and target explicit browser list

* build(lint-staged): remove superfulous git add

* build(lerna): lerna init

* build(docs): removed documentation.js auto generation

* feat(fontface): now defaults to looking for local font first

Default is now to look for a local font of the same family-name before downloading. Can be turned
off by passing null to localFonts.

BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior.

* feat(important): important helper for module rule specificity

important helper for targeting specific rules in module returns for adding `!important`-level
specificity.

* chore(important): update to not mutate original parameter

* chore(important): add to index.js

* fix(triangle): triangle now properly supports inherit

triangle now returns properties in a way that allows inherit to work by declaring an individual side
for the triangle color.

* feat(cssvar): allow a default value for cssVar

Allow the user to pass a default value to cssVar for when a variable is not found.

* fix(between): added error case when to/from unit is differs from mix/max (#511)

* chore(library): update dependencies

Update dependencies and fix new flow error in triangle.test.js

* refactor(stripunit): fully deprecate returnUnit

Fully deprecate returnUnit functionality and refactor return.

* refactor(readablecolor): make strict mode default

Make strict mode default when passing custom colors.

* build(babel): enable bugfix: true

Enable bugfix:true in build and target explicit browser list

* build(lint-staged): remove superfulous git add

* build(lerna): lerna init

* feat(normalize): upgrade to normalize 8.0.1

* build(docs): removed documentation.js auto generation

* feat(fontface): now defaults to looking for local font first

Default is now to look for a local font of the same family-name before downloading. Can be turned
off by passing null to localFonts.

BREAKING CHANGE: localFont will now be populated by default and may have unexpected behavior.

* feat(important): important helper for module rule specificity

important helper for targeting specific rules in module returns for adding `!important`-level
specificity.

* chore(important): update to not mutate original parameter

* chore(important): add to index.js

* fix(triangle): triangle now properly supports inherit

triangle now returns properties in a way that allows inherit to work by declaring an individual side
for the triangle color.

* feat(cssvar): allow a default value for cssVar

Allow the user to pass a default value to cssVar for when a variable is not found.

* fix(between): added error case when to/from unit is different than min/max

Added an error case when the unit for to/fromSize is different than min/maxScreen. This was causing
bad calculations based on the differing scales.

BREAKING CHANGE: If you were using a mix of unit and unitless measure or working with different
units with similar scales (em/rem) you will now get an error where you may have been getting a
seemingly valid calculation.

fix #445

* feat(ellipsis): ellipsis now optionally supports multline truncation

* feat(easings): separate timingFunctions into separate easing functions (#513)

re #402

* chore(package.json): clean up and update deps

* Replace snapshots with specific expect statements

* chore(rebase): rebase on main

* docs(docs): return docs to build for V4

* fix(docs): properly set directory for pushstate-server

* build(workflows): update github workflows to only run on unbuntu and use latest versions

* fix(lineargradient): fix issues with rgba as first value with spaces

* feat(math): move non-standard formulas to exponentials presets

* build(package.json): prettier config and updated babel rollup plugin

* docs(docs): updates documentation index

* docs(easings): add easings to docs

* style(js): run new prettier config across all JS

* chore(package.json): add beta tag

* docs(timingfunctions): comment on timingFunctions deprecation

* chore(library): rebuild package

* chore(docs): add pushstate-server to docs

* fix(index.js): add easings to index.js for docs site build

* build(package.json): bump version for release

Co-authored-by: Vincent Ricard <magic@magicninja.org>
@bhough bhough closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants