toHaveStyleRule to work with not passed expected value and negated ".not" modifier #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to add compatibility with decimal values in media queries
* upstream/master: Update CHANGELOG.md v6.2.2 Remove object rest/spread notation to continue Node 6 support (#196) Update CHANGELOG.md v6.2.1 exclude empty nodes update README Add serializer and storybook note (#188) Change Value type to support react-native number props (#180) (#185) update CHANGELOG v6.2.0 check if global.Element exists upgrade dependencies Fix mediaRegex to allow dot special character (#182) Updated regex to match attribute change of v4 (#181) Export serializer (#173)
|
I think I said it many time, @santino, but your PRs are the best :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the input from #205 I'm creating this PR to add a feature to
toHaveStyleRuleto be able to work with a negated ".not" modifier and a not passed expected value to allow the following syntax:Key-points:
I know the work on this project is currently focused around compatibility with SCv4, however this should be merged on existing master and be followed by an new npm release.
This will not only allow existing users to benefit from this feature even before SCv4 work is completed but will also allow users who are not going to update to SCv4 in the near future from having a new feature available.
This PR can then be merged into the v4 branch to reflect the changes introduced.