Strip static class names from jest snapshot results #320
Conversation
There was a problem hiding this comment.
LGTM.
On their docs it says:
It hasn't any style attached to it. Instead, it's used to quickly identify which styled component a DOM objects belongs to or to make minor changes in the DevTools.
https://styled-components.com/docs/faqs#why-do-my-dom-nodes-have-two-classes
|
@igorrmotta any chance we can merge this in? I wrote up a blog post about my reasoning as well! |
|
@blnoonan Soz, I'm not a contributor. Can't merge your changes. However, I have published your changes to my own npm repo. I've been using for the past month, it fixes a lot of my issues. There is still some, but they are not getting in the way right now. You can find your changes published here. |
|
@probablyup hey, could you please take a look on this PR? |
|
@probablyup, @gsipos, @igorrmotta would it be possible to merge this PR? Ot what's blocking it? |
|
Can this be packaged in a new release? I'm pretty sure most of the |
Due to changes in styled-components v5, certain hashed class names are no longer being included in masterSheet, and therefore are not being serialized in snapshots by jest-styled-components.
Specifically, this occurs in the case where a styled component (
StyledDiv) refers to another styled component (StyledDiv = styled(BaseDiv)) and the base component (BaseDiv) is not referenced in the component tree.This PR proposes stripping all static
sc-prefixed classes from snapshot results as a brute force way to resolve this issue.Relevant styled-components doc:
https://styled-components.com/docs/advanced#referring-to-other-components
Relevant issues:
#307
#276