Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace lodash with lodash.difference #405

Open
hcourt opened this issue Nov 10, 2023 · 0 comments
Open

replace lodash with lodash.difference #405

hcourt opened this issue Nov 10, 2023 · 0 comments

Comments

@hcourt
Copy link

hcourt commented Nov 10, 2023

Lodash is a very large library that impacts performance of downstream projects, and importing it in its entirety is no longer required. This library should be changed to use a lodash.* package like so:

Proposed changes

https://github.com/styled-components/babel-plugin-styled-components/blob/main/src/minify/index.js#L1

import difference from 'lodash.difference'

https://github.com/styled-components/babel-plugin-styled-components/blob/main/package.json#L37

    "lodash.difference": "^4.5.0",

I have a local branch which does this that I would be happy to submit, but PR creation here is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant