Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in 1.12.1 #374

Open
spawnia opened this issue Mar 8, 2022 · 4 comments
Open

Performance regression in 1.12.1 #374

spawnia opened this issue Mar 8, 2022 · 4 comments

Comments

@spawnia
Copy link

spawnia commented Mar 8, 2022

Upgrading this library to 1.12.1 or above causes a massive slowdown of our test runs. Here is how long our tests run with different versions of this library:

  • 1.12.0: 175s
  • 1.12.1: 757s
  • 1.13.0: 884s
  • 2.0.6: 796s

Some details about our project:

  • node 14.18.3
  • webpack 5.70.0
  • @babel/core 7.17.5
  • styled-components 5.2.1
  • react 16.13.1
  • jest 26.6.3

Thanks for this library, please let me know if you need further details from me.

@agriffis
Copy link
Contributor

agriffis commented Apr 5, 2022

@spawnia Have you looked at the differences between 1.12.0 and 1.12.1 to see what might be causing this?

@agriffis
Copy link
Contributor

agriffis commented Apr 5, 2022

Actually it seems clear that the culprit would be the caching changes in #327

Not sure yet why those caused a slowdown, though.

@spawnia
Copy link
Author

spawnia commented Apr 6, 2022

Thanks for looking into this @agriffis. I did compare the two tags via v1.12.0...v1.12.1, but was intimated by the large number of changed lines. Turns out the actual code changes were quite small, you identified them correctly.

I also cannot tell why those changes would be an issue, I can just give you more information about our environment: we are consuming a component library which itself uses this plugin and is bundled with rollup, but the slowdown happens when updating the dependency in our main application. This main application does not use rollup.

@Malgalad
Copy link

Not fixed in 2.0.7. Dev build takes about 27s, while on 1.12.0 build runs in 7s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants