Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update main.yml #78

Merged
merged 3 commits into from Dec 13, 2021
Merged

chore: update main.yml #78

merged 3 commits into from Dec 13, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

No description provided.

@styfle
Copy link
Owner

styfle commented Apr 22, 2021

Did you test this to verify it works?

@MichaelDeBoey
Copy link
Contributor Author

access_token isn't necessary anymore as it's defaulted to {{ github.token }}

@styfle
Copy link
Owner

styfle commented Apr 27, 2021

Right, but did you test it? Push twice to confirm that the previous one cancels?

The purpose of the workflows here are to provide tests. And I only see one push.

@MichaelDeBoey
Copy link
Contributor Author

@styfle Is there anything I can do to get this one merged?

@styfle
Copy link
Owner

styfle commented Dec 13, 2021

Did you test how it works with private repos? Do they need to provide a secret here?

@MichaelDeBoey
Copy link
Contributor Author

This isn't a private repo, so we can merge this

@styfle styfle merged commit 6eefb17 into styfle:main Dec 13, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-3 branch December 13, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants