Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Initial test run): start timing the test run when logging that the run is starting #2496

Merged
merged 3 commits into from Sep 28, 2020
Merged

feat(Initial test run): start timing the test run when logging that the run is starting #2496

merged 3 commits into from Sep 28, 2020

Conversation

simondel
Copy link
Member

@simondel simondel commented Sep 25, 2020 •
edited

Fixes #2477

nicojs
nicojs requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!

Add a test? 🤷‍♂️

@simondel
Copy link
Member Author

Great!!!

Add a test? 🤷‍♂️

@nicojs How would you go about testing this?

nicojs
nicojs requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use the global timer here. You're working on a fix if I'm not mistaken.

@simondel
Copy link
Member Author

We should not use the global timer here. You're working on a fix if I'm not mistaken.

Yes, we still use the global timer, but we get the time based on the marker that was placed at the start of the test run. This marker was already used to report the net and overhead ms time.

nicojs
nicojs approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a unit test for Timer

@nicojs nicojs merged commit 4f5a37e into epic/mutation-switching Sep 28, 2020
@nicojs nicojs deleted the 2477-move-testrun-timer-marker branch September 28, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.0.0.Beta does not correctly report the initial test run time
2 participants
@simondel @nicojs