fix(options): resolve false positives in unknown options warning #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't give a warning for "packageManager" config option * Use `commander.opts` to retrieve options to make sure we don't get unknown properties.
|
Do we even have to write it to the config file? |
|
Nope, we dont. But we did it in the past, and that will lead to a lot of warnings. I can see some use for it in the future. Let me write some more tests for this one |
|
Done, added tests for all CLI options |
simondel
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commander.optsto retrieve options to make sure we don't get unknown properties.Fixes #2209