New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(stryker): #336 Configurable tmp folder location #1644
Conversation
I've made some changes. 2 things mainly:
We could still improve on the dependency injection logic. Especially the passing around of the temp dir variable across multiple constructors. But it is already a big improvement. I didn't update the unit tests or anything, you want to take that? 😅 |
@nicojs what do you think? ☝️ |
@@ -256,10 +256,11 @@ describe(Stryker.name, () => { | |||
expect(mutationTestExecutorMock.run).calledWith(mutants); | |||
}); | |||
|
|||
it('should clean the stryker temp folder', async () => { | |||
// TODO: how to test it | |||
xit('should clean the stryker temp folder', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed anymore. typed-inject
is now responsible for the disposing of it.
@brunoqueiros I've made some changes. Namely:
I will merge it if the build is green. 💚 Sorry it took so long. I was on vacation and didn't get around to looking at this until now. 😥 |
Ability to specify a different temporary folder instead of
.stryker-tmp
. Solution based on #475