Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix README sections order #578

Merged
merged 1 commit into from Jun 23, 2020
Merged

docs: fix README sections order #578

merged 1 commit into from Jun 23, 2020

Conversation

agnes512
Copy link
Contributor

@agnes512 agnes512 commented Jun 8, 2020

Fix the order to make it consistent with other connector README files

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@agnes512 agnes512 marked this pull request as ready for review June 11, 2020 17:37
dhmlau
dhmlau approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a suggestion of moving the release note at the bottom.

README.md Outdated
@@ -494,3 +433,64 @@ export class User extends Entity {
## Release notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move the release notes at the bottom.

@agnes512
Copy link
Contributor Author

@slnode test please

@agnes512 agnes512 force-pushed the fix-order branch 2 times, most recently from 790ffd1 to 856523c Compare June 17, 2020 21:41
@agnes512
Copy link
Contributor Author

@slnode test please

@agnes512
Copy link
Contributor Author

The change is unrelated to bluemix-security@develop failure.

@agnes512 agnes512 merged commit c025814 into master Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-order branch June 23, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@nabdelgadir nabdelgadir Awaiting requested review from nabdelgadir

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agnes512 @dhmlau