Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new .generate_header method for webhooks #916

Merged
merged 1 commit into from Apr 27, 2020

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Apr 27, 2020

Adds a new generate_header method for the webhooks module, following
up #915. This method doesn't help in any way with webhook verification,
but may be useful to users in their test suites as it allows them to
easily simulate the contents of a header that Stripe might have sent.

We briefly discussed an alternative design here, but this one seems like
the best fit:
#915 (comment)

r? @ob-stripe
cc @stripe/api-libraries

Adds a new `generate_header` method for the webhooks module, following
up #915. This method doesn't help in any way with webhook verification,
but may be useful to users in their test suites as it allows them to
easily simulate the contents of a header that Stripe might have sent.

We briefly discussed an alternative design here, but this one seems like
the best fit:
#915 (comment)
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@brandur-stripe
Copy link
Contributor

Merci!

@brandur-stripe brandur-stripe merged commit 58fdde1 into master Apr 27, 2020
@brandur-stripe
Copy link
Contributor

Released as 5.20.0.

@jarthod
Copy link

jarthod commented Apr 28, 2020

Nice, thanks ;)

@remi-stripe remi-stripe deleted the brandur-generate-header branch September 28, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants